Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jpeach
Copy link
Contributor

@jpeach jpeach commented Jul 23, 2020

If the cluster has the ExtensionService CRD installed, inform on
ExtensionService resources and update the DAG cache.

This fixes #2712.

Signed-off-by: James Peach [email protected]

If the cluster has the ExtensionService CRD installed, inform on
ExtensionService resources and update the DAG cache.

This fixes projectcontour#2712.

Signed-off-by: James Peach <[email protected]>
@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #2724 into master will increase coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2724      +/-   ##
==========================================
+ Coverage   76.90%   76.91%   +0.01%     
==========================================
  Files          72       72              
  Lines        5715     5727      +12     
==========================================
+ Hits         4395     4405      +10     
- Misses       1228     1230       +2     
  Partials       92       92              
Impacted Files Coverage Δ
cmd/contour/serve.go 0.00% <0.00%> (ø)
internal/dag/cache.go 98.17% <100.00%> (+0.07%) ⬆️
internal/k8s/converter.go 38.29% <100.00%> (+1.34%) ⬆️

Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpeach jpeach merged commit 189190d into projectcontour:master Jul 24, 2020
@jpeach jpeach deleted the watch-extensions branch July 24, 2020 03:52
tthebst pushed a commit to tthebst/contour that referenced this pull request Aug 6, 2020
If the cluster has the ExtensionService CRD installed, inform on
ExtensionService resources and update the DAG cache.

This fixes projectcontour#2712.

Signed-off-by: James Peach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auth: Add an Informer to watch ExtensionServices

3 participants