use internal/timeout for config file timeouts #2721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes all timeouts within the TimeoutConfig block in the config file to use internal/timeout.Setting, to be consistent with timeouts specified in HTTPProxy. Signed-off-by: Steve Kriss <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2721 +/- ##
==========================================
+ Coverage 76.90% 77.00% +0.10%
==========================================
Files 72 72
Lines 5715 5697 -18
==========================================
- Hits 4395 4387 -8
+ Misses 1228 1223 -5
+ Partials 92 87 -5
|
stevesloka
reviewed
Jul 22, 2020
| StreamIdleTimeout: ctx.StreamIdleTimeout, | ||
| MaxConnectionDuration: ctx.MaxConnectionDuration, | ||
| DrainTimeout: ctx.DrainTimeout, | ||
| ConnectionIdleTimeout: timeout.Parse(ctx.ConnectionIdleTimeout), |
Member
There was a problem hiding this comment.
What happens if someone passes an invalid config option, it's disabled?
Member
Author
There was a problem hiding this comment.
Currently yes, it would be disabled, which is consistent with how timeouts specified in HTTPProxy are treated today. But there's discussion in #2697 about bubbling these up as errors instead, which I think makes more sense.
stevesloka
approved these changes
Jul 22, 2020
jpeach
approved these changes
Jul 23, 2020
tthebst
pushed a commit
to tthebst/contour
that referenced
this pull request
Aug 6, 2020
Changes all timeouts within the TimeoutConfig block in the config file to use internal/timeout.Setting, to be consistent with timeouts specified in HTTPProxy. Signed-off-by: Steve Kriss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes all timeouts within the TimeoutConfig block in the config
file to use internal/timeout.Setting, to be consistent with timeouts
specified in HTTPProxy.
Signed-off-by: Steve Kriss [email protected]
updates #2697
Couple notes for reviewers:
RequestTimeoutconfig field; that's slated to move into TimeoutConfig per move serveContext.RequestTimeout into TimeoutConfig and drop old field #2690 and the new field will use this pattern.