internal/dag: Refactor some logic from builder into KubernetesCache #2802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2802 +/- ##
==========================================
+ Coverage 76.76% 76.78% +0.01%
==========================================
Files 73 73
Lines 5665 5669 +4
==========================================
+ Hits 4349 4353 +4
Misses 1228 1228
Partials 88 88
|
4d98070 to
ebb00a2
Compare
Moves some common components from the builder into the KubernetesCache so that it can be reused from other components. Updates projectcontour#2226 Signed-off-by: Steve Sloka <[email protected]>
ebb00a2 to
bc77c7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves some common components from the builder into the KubernetesCache
so that it can be reused from other components. This is the first of a few PRs in refactoring
the builder out.
Updates #2226
Signed-off-by: Steve Sloka [email protected]