internal/dag: fix adding a ServiceCluster entry #2870
Merged
+59
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`(*ServiceCluster).AddWeightedService` didn't copy the service name properly, leading to a failure to match the service endpoints. Copy the correct fields and add tests for `ServiceCluster` type. This updates projectcontour#2713. Signed-off-by: James Peach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(*ServiceCluster).AddWeightedServicedidn't copy the service nameproperly, leading to a failure to match the service endpoints. Copy
the correct fields and add tests for
ServiceClustertype.This updates #2713.
Signed-off-by: James Peach [email protected]