internal/dag: move logger from builder to processors #2892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the logrus.FieldLogger from the DAG builder and adds it directly to the IngressProcessor where it's used. Updates projectcontour#2226 Signed-off-by: Steve Kriss <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2892 +/- ##
==========================================
+ Coverage 75.59% 75.61% +0.02%
==========================================
Files 80 80
Lines 5932 5934 +2
==========================================
+ Hits 4484 4487 +3
Misses 1356 1356
+ Partials 92 91 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the logrus.FieldLogger from the DAG builder and adds
it directly to the IngressProcessor where it's used.
Updates #2226
Signed-off-by: Steve Kriss [email protected]