testsuite: add a basic external auth test #2955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48710d9 to
20a2522
Compare
Codecov Report
@@ Coverage Diff @@
## main #2955 +/- ##
=======================================
Coverage 75.01% 75.01%
=======================================
Files 89 89
Lines 5803 5803
=======================================
Hits 4353 4353
Misses 1355 1355
Partials 95 95 |
skriss
reviewed
Sep 30, 2020
| import data.contour.http.response | ||
|
|
||
| Response := client.Get({ | ||
| "url": url.https(sprintf("/first/route/%d", [time.now_ns()])), |
Member
There was a problem hiding this comment.
it'd be helpful to add a comment somewhere explaining the authserver behavior that's being used here (authorize if path contains allow, otherwise deny)
Contributor
Author
There was a problem hiding this comment.
Good point, I added a comment.
skriss
approved these changes
Sep 30, 2020
Member
skriss
left a comment
There was a problem hiding this comment.
LGTM apart from one request for comments.
Add a basic integration test for an external authorization server. This ensures that if the authorization server is present, context is propagated correctly, and authorization can be disabled on routes. This updates projectcontour#2717. Signed-off-by: James Peach <[email protected]>
20a2522 to
ce9137d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a basic integration test for an external authorization server. This
ensures that if the authorization server is present, context is propagated
correctly, and authorization can be disabled on routes.
This updates #2717.
Signed-off-by: James Peach [email protected]