Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jpeach
Copy link
Contributor

@jpeach jpeach commented Oct 2, 2020

Add a guide that gives an overview of how external authorization works,
and a worked example of deploying it with contour-authserver.

This updates #2716.

Signed-off-by: James Peach [email protected]

@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #2970 into main will decrease coverage by 1.40%.
The diff coverage is 87.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2970      +/-   ##
==========================================
- Coverage   76.45%   75.04%   -1.41%     
==========================================
  Files          74       89      +15     
  Lines        5806     5803       -3     
==========================================
- Hits         4439     4355      -84     
- Misses       1272     1354      +82     
+ Partials       95       94       -1     
Impacted Files Coverage Δ
cmd/contour/certgen.go 29.72% <0.00%> (-2.22%) ⬇️
cmd/contour/cli.go 0.00% <0.00%> (ø)
cmd/contour/contour.go 0.00% <0.00%> (-4.23%) ⬇️
cmd/contour/ingressstatus.go 33.33% <0.00%> (-2.16%) ⬇️
cmd/contour/leadership.go 0.00% <0.00%> (ø)
internal/annotation/annotations.go 100.00% <ø> (ø)
internal/build/version.go 0.00% <ø> (ø)
internal/contour/observer.go 0.00% <0.00%> (ø)
internal/envoy/route.go 86.36% <ø> (-12.03%) ⬇️
internal/envoy/v2/endpoint.go 100.00% <ø> (ø)
... and 141 more

Copy link
Member

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of small suggestions.

Add a guide that gives an overview of how external authorization works,
and a worked example of deploying it with `contour-authserver`.

This updates projectcontour#2716.

Signed-off-by: James Peach <[email protected]>
@jpeach jpeach merged commit aab8507 into projectcontour:main Oct 2, 2020
@jpeach jpeach deleted the doc-auth-guide branch October 2, 2020 05:48
@stevesloka
Copy link
Member

I know this is already merged, but would be nice to have just plain yaml to apply and not require Kustomize or cert-manager. The auth integration is complex enough without adding those bits into the mix.

@jpeach
Copy link
Contributor Author

jpeach commented Oct 2, 2020

I know this is already merged, but would be nice to have just plain yaml to apply and not require Kustomize or cert-manager. The auth integration is complex enough without adding those bits into the mix.

Yeh, the downside of plain yaml there is that there's a large amount needed to deploy the auth server, and it's not especially relevant to the example (which is focusing on the integration points with Contour).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants