Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jpeach
Copy link
Contributor

@jpeach jpeach commented Oct 14, 2020

Add a lifecycle/needs-triage label and apply it on all new
issues opened with the issue templates.

This fixes #2981.

Signed-off-by: James Peach [email protected]

Add a `lifecycle/needs-triage` label and apply it on all new
issues opened with the issue templates.

This fixes projectcontour#2981.

Signed-off-by: James Peach <[email protected]>
@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #3028 into main will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3028      +/-   ##
==========================================
- Coverage   74.52%   74.49%   -0.04%     
==========================================
  Files          92       92              
  Lines        5963     5963              
==========================================
- Hits         4444     4442       -2     
- Misses       1422     1423       +1     
- Partials       97       98       +1     
Impacted Files Coverage Δ
internal/dag/cache.go 95.36% <0.00%> (-0.78%) ⬇️

Copy link
Member

@stevesloka stevesloka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

The interesting bit is I don't know if the labels are always getting added automagically. I've created some issues recently that don't have the kind/feature label added. /shrug

Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skriss skriss merged commit 04973d7 into projectcontour:main Oct 14, 2020
@skriss
Copy link
Member

skriss commented Oct 14, 2020

The interesting bit is I don't know if the labels are always getting added automagically. I've created some issues recently that don't have the kind/feature label added. /shrug

If you go directly to https://github.com/projectcontour/contour/issues/new, no template is used so no labels are added, but if you choose a template that seems to add the labels properly. Maybe that explains what you're seeing?

@stevesloka
Copy link
Member

Yup possibly, I'll have to pay more attention next time I open an issue.

As an aside thinking about this more (I know it's already merged), should we remove the "bug" or "feature" label from the default until after it's been triaged? Seems like that output should be a result of the triage process.

@jpeach
Copy link
Contributor Author

jpeach commented Oct 14, 2020

If you go directly to https://github.com/projectcontour/contour/issues/new, no template is used so no labels are added

Good find!

As an aside thinking about this more (I know it's already merged), should we remove the "bug" or "feature" label from the default until after it's been triaged? Seems like that output should be a result of the triage process.

I think that when we do initial triage, we can modify labels however we think makes sense for the issue. Applying them up front isn't meant to be carved in stone; it's just an initial hint (and hopefully labor-saving). As we get more regular at triage, I'd expect that our process and expectations will solidify as we get experience with what works for us and what metadata we need. We can definitely revisit this, and should plan to make improvements.

@jpeach jpeach deleted the label-needs-triage branch October 16, 2020 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a lifecycle/needs-triage issue label

3 participants