-
Notifications
You must be signed in to change notification settings - Fork 703
site: add lifecycle/needs-triage label
#3028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add a `lifecycle/needs-triage` label and apply it on all new issues opened with the issue templates. This fixes projectcontour#2981. Signed-off-by: James Peach <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #3028 +/- ##
==========================================
- Coverage 74.52% 74.49% -0.04%
==========================================
Files 92 92
Lines 5963 5963
==========================================
- Hits 4444 4442 -2
- Misses 1422 1423 +1
- Partials 97 98 +1
|
stevesloka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The interesting bit is I don't know if the labels are always getting added automagically. I've created some issues recently that don't have the kind/feature label added. /shrug
skriss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If you go directly to https://github.com/projectcontour/contour/issues/new, no template is used so no labels are added, but if you choose a template that seems to add the labels properly. Maybe that explains what you're seeing? |
|
Yup possibly, I'll have to pay more attention next time I open an issue. As an aside thinking about this more (I know it's already merged), should we remove the "bug" or "feature" label from the default until after it's been triaged? Seems like that output should be a result of the triage process. |
Good find!
I think that when we do initial triage, we can modify labels however we think makes sense for the issue. Applying them up front isn't meant to be carved in stone; it's just an initial hint (and hopefully labor-saving). As we get more regular at triage, I'd expect that our process and expectations will solidify as we get experience with what works for us and what metadata we need. We can definitely revisit this, and should plan to make improvements. |
Add a
lifecycle/needs-triagelabel and apply it on all newissues opened with the issue templates.
This fixes #2981.
Signed-off-by: James Peach [email protected]