internal: fix issue with duplicate DAG services & clusters #3095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3095 +/- ##
==========================================
+ Coverage 73.19% 73.25% +0.06%
==========================================
Files 103 103
Lines 6421 6421
==========================================
+ Hits 4700 4704 +4
+ Misses 1618 1616 -2
+ Partials 103 101 -2
|
jpeach
reviewed
Nov 4, 2020
jpeach
approved these changes
Nov 4, 2020
8812c63 to
bcfcb9b
Compare
Member
Author
Made this change as well. |
jpeach
approved these changes
Nov 4, 2020
Fixes an issue where services were being added as DAG roots, even though they're always children of a route, so by definition not roots. Also fixes a bug in the endpoints translator that did not properly track already-visited service clusters to avoid processing them twice. Signed-off-by: Steve Kriss <[email protected]>
bcfcb9b to
4ab5d57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where services were being added as DAG roots, even
though they're always children of a route, so by definition not
roots. Also fixes a bug in the endpoints translator that did not
properly track already-visited service clusters to avoid processing
them twice.
Signed-off-by: Steve Kriss [email protected]