site: Fixup some nits with working on the xds migration guide #3106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3106 +/- ##
=======================================
Coverage 73.23% 73.23%
=======================================
Files 103 103
Lines 6422 6422
=======================================
Hits 4703 4703
Misses 1617 1617
Partials 102 102 |
skriss
reviewed
Nov 6, 2020
site/_guides/xds-migration.md
Outdated
| Contour v1.10.0 will serve both v2 and v3 xDS versions from the same gRPC endpoint. | ||
| This allows a fleet of Envoy instances to move from the `v2` xDS Resource API version gradually to the `v3` version. | ||
| When users have an existing Contour installation and wish to upgrade without dropping connections, users should first upgrade Contour to v1.10.0 which will serve both v2 and v3 xDS versions from the same gRPC endpoint. | ||
| Next, change the Envoy Daemonset or deployment to include `--xds-resource-version=v3` which tells Envoy to upgrade to the v3 resource version. |
Member
There was a problem hiding this comment.
looking at this once more, it'd be helpful to reiterate here that this is a flag for the contour bootstrap command on the init container. You mention it in the previous section but could repeat it here, so folks don't think it's for the envoy command/container
Member
Author
There was a problem hiding this comment.
Ok I added some more bits, please take a look.
Signed-off-by: Steve Sloka <[email protected]>
skriss
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steve Sloka [email protected]