internal/featuretests: Move xDS version v2 to v3 features tests #3124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates projectcontour#1898 Signed-off-by: Steve Sloka <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #3124 +/- ##
=======================================
Coverage 76.24% 76.24%
=======================================
Files 117 117
Lines 7577 7578 +1
=======================================
+ Hits 5777 5778 +1
- Misses 1670 1671 +1
+ Partials 130 129 -1
|
skriss
approved these changes
Nov 12, 2020
Member
skriss
left a comment
There was a problem hiding this comment.
this LGTM. I mainly checked for any remaining v2 refs (there were none) and visually scanned the rest.
Just confirming that we're ready to delete the v2 tests? I think it's fine as we're about ready to start deleting all the v2 code, but just double-checking.
Member
Author
Yup! Next we should be able to just drop all the v2 bits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #1898
Signed-off-by: Steve Sloka [email protected]