Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@stevesloka
Copy link
Member

Fixes #1917

Signed-off-by: Steve Sloka [email protected]

@stevesloka stevesloka added this to the 1.11.0 milestone Nov 16, 2020
@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #3133 (2290ed8) into main (803f7d5) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3133      +/-   ##
==========================================
+ Coverage   74.10%   74.13%   +0.03%     
==========================================
  Files          96       96              
  Lines        6004     6004              
==========================================
+ Hits         4449     4451       +2     
+ Misses       1457     1456       -1     
+ Partials       98       97       -1     
Impacted Files Coverage Δ
internal/envoy/bootstrap.go 47.82% <ø> (ø)
internal/envoy/v3/tcp_keepalive.go 100.00% <ø> (ø)
internal/envoy/v3/tls.go 100.00% <ø> (ø)
internal/fixture/log.go 55.55% <ø> (ø)
internal/fixture/service.go 100.00% <ø> (ø)
internal/k8s/log.go 0.00% <ø> (ø)
internal/dag/cache.go 96.13% <0.00%> (+0.77%) ⬆️

Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, LGTM!

@stevesloka stevesloka merged commit 8fbbac6 into projectcontour:main Nov 16, 2020
@stevesloka stevesloka deleted the copyrightHeader branch November 16, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI should check appropriate copyright headers are in place

2 participants