site/guides: Add cert-manager example to explain how to use Certificate resources #3175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Blocked behind #3172 |
Codecov Report
@@ Coverage Diff @@
## main #3175 +/- ##
=======================================
Coverage 74.00% 74.00%
=======================================
Files 96 96
Lines 6001 6001
=======================================
Hits 4441 4441
Misses 1464 1464
Partials 96 96 |
11f99cf to
adbc379
Compare
skriss
reviewed
Dec 3, 2020
skriss
reviewed
Dec 4, 2020
Member
skriss
left a comment
There was a problem hiding this comment.
couple minor language comments, but looks pretty good
…te resources Update the cert-manager guide to explain how to use cert-manager Certificate resources instead of Ingress shim resources to request certificates via cert-manager. Fixes projectcontour#2709 Signed-off-by: Steve Sloka <[email protected]>
Signed-off-by: Steve Sloka <[email protected]>
Signed-off-by: Steve Sloka <[email protected]>
Signed-off-by: Steve Sloka <[email protected]>
83739ff to
795391c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the cert-manager guide to explain how to use cert-manager Certificate resources
instead of Ingress shim resources to request certificates via cert-manager.
Fixes #2709
Fixes #2018
Signed-off-by: Steve Sloka [email protected]