cmd/contour: update CLI commands to use xDS v3 #3202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the CLI commands to use xDS v3. Also fixes a panic when no user agent build version is present. Updates projectcontour#3200. Signed-off-by: Steve Kriss <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #3202 +/- ##
==========================================
+ Coverage 74.04% 74.09% +0.04%
==========================================
Files 97 97
Lines 6019 6021 +2
==========================================
+ Hits 4457 4461 +4
+ Misses 1468 1467 -1
+ Partials 94 93 -1
|
Member
sunjayBhatia
left a comment
There was a problem hiding this comment.
go list -f '{{ join .Imports "\n" }}' ./... | grep -E 'envoy.*v2'
Doesn't return any v2 packages 👍
Just one comment about possibly adding test coverage
Signed-off-by: Steve Kriss <[email protected]>
sunjayBhatia
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the CLI commands to use xDS v3. Also fixes a panic
when no user agent build version is present.
Updates #3200.
Signed-off-by: Steve Kriss [email protected]