Thanks to visit codestin.com
Credit goes to github.com

Skip to content

examples: update Envoy to 1.16.2 #3211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stevesloka merged 1 commit into from
Dec 17, 2020
Merged

examples: update Envoy to 1.16.2 #3211

stevesloka merged 1 commit into from
Dec 17, 2020

Conversation

@skriss
Copy link
Member

@skriss skriss commented Dec 16, 2020

Signed-off-by: Steve Kriss [email protected]

The compatibility matrix will need to be updated when 1.10.1 and 1.11 are cut.

@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #3211 (2e8f754) into main (c05ddbd) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3211      +/-   ##
==========================================
- Coverage   74.95%   74.92%   -0.04%     
==========================================
  Files          97       97              
  Lines        6025     6025              
==========================================
- Hits         4516     4514       -2     
- Misses       1402     1403       +1     
- Partials      107      108       +1
Impacted Files Coverage Δ
internal/dag/cache.go 95.25% <0.00%> (-0.80%) ⬇️

@danehans
Copy link
Contributor

danehans commented Dec 17, 2020

@skriss should "Note: These extensions are tested against Envoy v1.16.1." in https://projectcontour.io/resources/envoy/ get updated to reference v1.16.2?

@danehans
Copy link
Contributor

danehans commented Dec 17, 2020

xref: projectcontour/contour-operator#165

@skriss
Copy link
Member Author

skriss commented Dec 17, 2020

@skriss should "Note: These extensions are tested against Envoy v1.16.1." in https://projectcontour.io/resources/envoy/ get updated to reference v1.16.2?

Well, @stevesloka just did this testing, and it was against 1.16.1, so not sure we just want to update the text if we haven't actually retested. @stevesloka thoughts? In any case, we can make that change (if needed) as part of updating the compat matrix for the release.

@stevesloka
Copy link
Member

stevesloka commented Dec 17, 2020

Yup my testing was technically on 1.16.1, but I'd expect it to work fine with 1.16.2.

stevesloka
stevesloka approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@stevesloka stevesloka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@stevesloka stevesloka merged commit 1f70f8c into projectcontour:main Dec 17, 2020
@stevesloka
Copy link
Member

stevesloka commented Dec 17, 2020

I just built a new image: stevesloka/envoy:v1.16.2.contour

@skriss skriss deleted the envoy-1.16.2 branch December 17, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunjayBhatia sunjayBhatia Awaiting requested review from sunjayBhatia

2 more reviewers

@stevesloka stevesloka stevesloka approved these changes

@youngnick youngnick youngnick approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@skriss @danehans @stevesloka @youngnick