Thanks to visit codestin.com
Credit goes to github.com

Skip to content

(release-1-16) Cherrypick #3834 #3974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skriss merged 4 commits into from
Aug 25, 2021
Merged

(release-1-16) Cherrypick #3834 #3974

skriss merged 4 commits into from
Aug 25, 2021

Conversation

@stevesloka
Copy link
Member

@stevesloka stevesloka commented Aug 25, 2021

Move to Envoy Admin over unix socket to mitigate security issues with external name services.

Signed-off-by: Steve Sloka [email protected]

@stevesloka
Cherrypick projectcontour#3834
e9876d1 
Move to Envoy Admin over unix socket to mitigate security issues with external name services.

Signed-off-by: Steve Sloka <[email protected]>
@stevesloka stevesloka requested a review from a team as a code owner August 25, 2021 14:30
@stevesloka stevesloka requested review from skriss and sunjayBhatia and removed request for a team August 25, 2021 14:30
@stevesloka
Copy link
Member Author

stevesloka commented Aug 25, 2021

The e2e's failed for me locally, but not sure if a local dep thing or not, waiting to see what CI does.

@stevesloka stevesloka changed the title Cherrypick #3834 Cherrypick #3834 into 1.16 Aug 25, 2021
@codecov
Copy link

codecov bot commented Aug 25, 2021 •
edited
Loading

Codecov Report

Merging #3974 (f7bdec4) into release-1.16 (3fe2f3f) will increase coverage by 0.10%.
The diff coverage is 84.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           release-1.16    #3974      +/-   ##
================================================
+ Coverage         76.73%   76.84%   +0.10%     
================================================
  Files               107      107              
  Lines              8306     8404      +98     
================================================
+ Hits               6374     6458      +84     
- Misses             1805     1819      +14     
  Partials            127      127
Impacted Files Coverage Δ
cmd/contour/bootstrap.go 0.00% <0.00%> (ø)
cmd/contour/contour.go 0.00% <0.00%> (ø)
cmd/contour/serve.go 11.11% <0.00%> (ø)
cmd/contour/shutdownmanager.go 29.57% <0.00%> (-6.46%) ⬇️
internal/envoy/bootstrap.go 55.88% <100.00%> (+5.88%) ⬆️
internal/envoy/v3/bootstrap.go 91.90% <100.00%> (ø)
internal/envoy/v3/listener.go 98.42% <100.00%> (+0.03%) ⬆️
internal/envoy/v3/stats.go 100.00% <100.00%> (ø)
internal/featuretests/v3/envoy.go 100.00% <100.00%> (ø)
internal/featuretests/v3/featuretests.go 87.22% <100.00%> (+0.17%) ⬆️
... and 2 more

@stevesloka stevesloka changed the title Cherrypick #3834 into 1.16 (release-1-16) Cherrypick #3834 Aug 25, 2021
sunjayBhatia
sunjayBhatia requested changes Aug 25, 2021
View reviewed changes
Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the infra test suite applies cleanly here without adding the deployment e2e package as well since it depends on that and that was not present in this release branch yet

we could forgo adding those tests here as well since we've been manually verifying for older releases to reduce the cherry-pick headache

@stevesloka
remove infra from test
377e7c4 
Signed-off-by: Steve Sloka <[email protected]>
@stevesloka stevesloka force-pushed the cherrypickAdminSocket1-16 branch from 1120891 to 377e7c4 Compare August 25, 2021 19:26
@stevesloka
Copy link
Member Author

stevesloka commented Aug 25, 2021

@sunjayBhatia I removed the infra suite.

@skriss
Copy link
Member

skriss commented Aug 25, 2021

Looks like it may need a go mod tidy and also some stuff not compiling in test/e2e - should all changes to E2E's be backed out?

@sunjayBhatia
Copy link
Member

sunjayBhatia commented Aug 25, 2021

Looks like it may need a go mod tidy and also some stuff not compiling in test/e2e - should all changes to E2E's be backed out?

yeah i think just removing all test/e2e changes is good for this

@stevesloka stevesloka force-pushed the cherrypickAdminSocket1-16 branch from b93112c to ed5d714 Compare August 25, 2021 20:08
@skriss skriss merged commit 4f1c3d8 into projectcontour:release-1.16 Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skriss skriss skriss approved these changes

@sunjayBhatia sunjayBhatia sunjayBhatia approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stevesloka @skriss @sunjayBhatia