Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix issue of too many logs due to raw bytes #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jschwinger233 merged 1 commit into from
Oct 28, 2021
Merged

Fix issue of too many logs due to raw bytes #498

jschwinger233 merged 1 commit into from
Oct 28, 2021

Conversation

@jschwinger233
Copy link
Member

@jschwinger233 jschwinger233 commented Oct 28, 2021 •
edited
Loading

  1. CreateWorkload 里的用户请求用 compact 模式, 打印在一行
  2. LinuxFile 和 RawArgs 这两个 bytes 字段, 实现了 String() 和 LitterDump() 方法, 避免输出 raw bytes, 只输出长度和其他信息

@jschwinger233
Copy link
Member Author

jschwinger233 commented Oct 28, 2021

@DuodenumL

@jschwinger233 jschwinger233 changed the title [WIP] Fix issue of too many logs due to raw bytes Fix issue of too many logs due to raw bytes Oct 28, 2021
DuodenumL
DuodenumL reviewed Oct 28, 2021
View reviewed changes
types/options.go Outdated

// LitterDump fro litter.Dumper
func (r RawArgs) LitterDump(w io.Writer) {
w.Write([]byte(string(r))) // nolint:errcheck // here can't import core/log due to cycle dependence
Copy link
Contributor

@DuodenumL DuodenumL Oct 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里应该用r就行，不用转两遍？

@jschwinger233 jschwinger233 changed the title Fix issue of too many logs due to raw bytes [WIP] Fix issue of too many logs due to raw bytes Oct 28, 2021
@jschwinger233 jschwinger233 changed the title [WIP] Fix issue of too many logs due to raw bytes Fix issue of too many logs due to raw bytes Oct 28, 2021
@jschwinger233 jschwinger233 merged commit 5678660 into projecteru2:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DuodenumL DuodenumL DuodenumL left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jschwinger233 @DuodenumL