avoid redundant logs in "makeClient" #499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
store/etcdv3/node.go
Outdated
| log.Warnf(ctx, "[makeClient] Get key failed %v", err) | ||
| ev, err := m.GetOne(ctx, fmt.Sprintf(keyFormats[i], node.Name)) | ||
| if err != nil { | ||
| if !strings.Contains(err.Error(), types.ErrBadCount.Error()) { |
Member
There was a problem hiding this comment.
476c107 to
cdfd68b
Compare
| v, err := r.GetOne(ctx, fmt.Sprintf(keyFormats[i], node.Name)) | ||
| if err != nil { | ||
| log.Warnf(ctx, "[makeClient] Get key failed %v", err) | ||
| if !isRedisNoKeyError(err) { |
jschwinger233
approved these changes
Oct 29, 2021
Member
|
自己的本地跑一下, 创建一个容器试试 |
cdfd68b to
900ce98
Compare
Contributor
Author
用agent调用SetNode试了一下，没啥问题... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在缓存机制挪到GetEngine里面之后，这里的日志每次调用GetNode的时候都会打一遍，数量超大。
现在改成了：如果key不存在就不会报错。