Fix thg bugs of "make test" and "getFullResult" #503
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
上一个PR里我按照自己的理解改动了getFullResult,但是其实我的理解是有问题的!这里回滚一下。
如果CPU map是{0:200, 1: 200},那么对于cpu=1的申请可以分配4个,而不是两个。之前我以为“整数核不应该被切分”的意思是“至少在单次分配中保证整数核是被独占的”,完全错了。
之前没有发现这个不一致的问题,部分原因是提PR的时候check没报错。查了一下发现GNU make 4.3会把make test里的那些命令按照加分号的形式顺序执行,导致只要make test的最后一句命令的exit code会覆盖之前命令的exit code。这里用偷鸡摸狗的方式改了一下Makefile,使其功能恢复正常。