Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@DuodenumL
Copy link
Contributor

上一个PR里我按照自己的理解改动了getFullResult,但是其实我的理解是有问题的!这里回滚一下。

如果CPU map是{0:200, 1: 200},那么对于cpu=1的申请可以分配4个,而不是两个。之前我以为“整数核不应该被切分”的意思是“至少在单次分配中保证整数核是被独占的”,完全错了。

之前没有发现这个不一致的问题,部分原因是提PR的时候check没报错。查了一下发现GNU make 4.3会把make test里的那些命令按照加分号的形式顺序执行,导致只要make test的最后一句命令的exit code会覆盖之前命令的exit code。这里用偷鸡摸狗的方式改了一下Makefile,使其功能恢复正常。

@jschwinger233 jschwinger233 changed the title Fix thg bugs of "make test" and "getFullResult" [WIP] Fix thg bugs of "make test" and "getFullResult" Nov 10, 2021
@jschwinger233 jschwinger233 changed the title [WIP] Fix thg bugs of "make test" and "getFullResult" Fix thg bugs of "make test" and "getFullResult" Nov 10, 2021
@CMGS CMGS merged commit a0b6f3a into projecteru2:master Nov 10, 2021
@CMGS
Copy link
Contributor

CMGS commented Nov 10, 2021

哼哼

@DuodenumL
Copy link
Contributor Author

哼哼

但是cpu分配这块的逻辑我还是会重写的!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants