optimize "GetOutboundAddress" #581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
SRE催得比较急，我先合了，后续master上也应该跟进这个改动 |
Contributor
|
你要注意 core master 大为不同了…… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
有一些机器有内外网，希望eru-core在上报自己地址的时候报内网地址，否则即使agent只配了内网，也会尝试去连接外网的core，导致错误。
这个PR优化了一下get outbound address的过程。如果bind里指定了IP，并且不是0.0.0.0，那么就上报bind的地址。否则，按照旧的方式，根据配置里新增的
DialTarget（名字乱取的...）去拿一下IP。