call plugin in parallel #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ut |
CMGS
reviewed
Sep 21, 2023
resource/cobalt/call.go
Outdated
Comment on lines
24
to
25
| mu.Lock() | ||
| defer mu.Unlock() |
Contributor
There was a problem hiding this comment.
我觉得不如用个 buffer chan 传错误出来……反正长度是可控的
Contributor
There was a problem hiding this comment.
results 可以无锁 map，我记得 core 依赖了个haxmap 吧
Contributor
Author
There was a problem hiding this comment.
可以，这个UT又很奇怪，完全不相干的地方，而且本地跑好像没问题
Contributor
Author
There was a problem hiding this comment.
mutex删了，haxmap没法用，plugin不能作为它的key，感觉这么写更丑了
Contributor
There was a problem hiding this comment.
我看了下既然都用上了 sync.Map, 不如更进一步 sync.Map 存 error，看上去没这么丑？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.