Add initial support for Reline on Ruby 3.3+ #2298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aa46ee8 to
bb02d8c
Compare
774e9a0 to
aed6633
Compare
aed6633 to
67f89be
Compare
8fe5364 to
f5d0316
Compare
This was referenced Oct 13, 2024
Merged
|
Nice to heard nice reline support get merged in 0.15.0!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Ruby 3.3 Readline was finally replaced by reline.
Currently pry kinda works, but has some edge cases like #2297 that were working on previous versions with Readline.
We can go back to older readline via installing `readline-ext'. ref As the default that come with ruby is Reline, we need some kind of support here.
This PR attempts to add reline support, multiline editing, and so on. Making Pry compatible.
Fixes: #2063 #1524 #2297 #2302 #1740 #1765 #1514 #2023