Fixes compatibility with ruby 3.3.5 #2318
Conversation
| gem 'rspec' | ||
|
|
||
| gem "psych", '<= 5.2.0' | ||
| gem 'fiddle' |
There was a problem hiding this comment.
Can you add to the PR which error was related to Fiddle?
There was a problem hiding this comment.
There was a problem hiding this comment.
As the 'fiddle' warnings are coming from Reline, I don't think we should fix by adding this dependency here
And it will also work in the future when Fiddle is not around..
The most recent version of reline fixed this, so I made another PR to ensure the CI runs with an recent release of Reline.
| gem "psych", '<= 5.2.0' | ||
| gem 'fiddle' | ||
| gem 'psych', '<= 5.2.0' | ||
| gem 'ostruct', '0.6.0' |
There was a problem hiding this comment.
ostruct usage was removed on #2307 (still unreleased)
|
I support this PR, but agree with comments to it. |
|
Thanks for the PR 🙌 and bringing my attention to that warning. Closing this as I merged #2320. Running the CI with an updated reline, takes care of 'fiddle' warnings. and ostruct was already removed in master. Need to prepare a new release for those fixes. |
When running the specs using ruby 3.3.5, there is a test failure due to the lack of the fiddle gem. This PR resolves this. This PR also resolves a depreciation warning for ruby 3.5: