Fix clipping with stroke composite #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a compositing issue where clipping layers and stroke effects were being applied in the wrong order, which was causing visual artifacts. The change involves moving the clipping layer application to occur after stroke processing rather than before.
- Move clipping layer compositing to occur after stroke application instead of before
- Add development dependency for ipykernel to improve development environment setup
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/psd_tools/composite/init.py | Reorders stroke and clipping layer processing to fix compositing bug |
| pyproject.toml | Adds ipykernel dependency and reformats dev dependencies list |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
tmp/ignore andipykernelfor development environmentipythonfrom the dev dependency, as it is not needed anywhere