-
Notifications
You must be signed in to change notification settings - Fork 1
Implement more accurate syllable counting rule for Polish #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 2 +1
Lines 22 35 +13
=========================================
+ Hits 22 35 +13
Continue to review full report at Codecov.
|
I don't have an access to a computer right now, but there seems to be a solution to the failing R CMD check on Ubuntu devel: https://community.rstudio.com/t/github-action-failure-with-rcmd-check-on-ubuntu-devel/129727. I'll try and implement it later today. |
I'm not sure how many differences there are between v2 check-standard and that check you used earlier, but I hope they are similar enough to not break your workflow. And, hopefully, this one works on Ubuntu devel too. |
In many languages (including Polish) having a list of all words with number of syllables for each of them is superfluous. There are a few rules that allow to correctly compute number of syllables for >99% of words, and they are as follows:
I had to rewrite the code a bit to allow a different set of syllable rules to be used (i.e. a different regex). Moreover:
sapply()
withvapply()
(the former simplifies uncontrollably)."en"
) to an empty named integer vector, so that the code doesn't try to subsetNULL
later on (which resulted in returning complete garbage).Tried to stick to your code style, I believe I succeeded at that. Should I add myself as a contributor?
Hopefully this will make it easier to implement other languages too!