Basic GitHub Actions test harness #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dgtized do you want me to review it or @jackrusher is going to take a look? |
|
Thanks, but I asked Jack about it, particularly to see if he had any ideas about the OSX issue. Apologies for all the test notification failures if you received those. I'll try and ping you directly if I have any questions or need your insight on a PR. Happy for the assistance if you have time of course! |
|
Disabling windows & OSX tests for now as they currently fail, better to have Linux as a canary and expand the testing surface area later. |
|
@jackrusher reviewed this over email, so merging as is. |
dgtized
added a commit
that referenced
this pull request
Nov 8, 2023
* New automated test harness for assertions of Processing and P5js behaviors [#384](#384), [#388](#388), [#390](#390) * Basic Github Actions test harness for existing `lein test` on Linux [#381](#381) * Fix for `#cljs.core/abs` compile warning [#380](#380) * Support for Processing 4.3, M1 hardware, JVM > 1.8 * Implement `fract` calculation [#392](#392) * Fix canvas resize and fullscreen behavior for p5js sketches [#393](#393) * Clojar release automation using Github Actions to generate snapshot and tagged jar files [#394](#394)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just runs the existing tests using
lein testinside of xvfb environment on ubuntu. While the tests currently report as passing, looking through the log of each test, there are some errors reported that should be investigated.The matrix build is enabled to attempt windows and macOS builds, but both are failing. The Windows build is failing in the checkout action, so will need to look upstream for that. The macOS build is making it all the way to lein test, but looks to be throwing some errors attempting to make graphic calls to a dynamic library from java 8. It's possible there is a workaround, but this may depend on upgrading from java 8, which is blocked on upstream processing/opengl problems for now.