asynq: fix asyncio mock #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewers: dkang Test Plan: unit tests Differential Revision: Asana Tasks: Screenshot: CC: Deploy To:
994125010
commented
Jun 4, 2025
| # so we can also mock non-functions for compatibility | ||
| if callable(mock_fn): | ||
| async_fn = _AsyncWrapper(mock_fn) | ||
| async_fn = _AsynqWrapper(mock_fn) |
Contributor
Author
There was a problem hiding this comment.
renamed this since the attribute had to be renamed asynq to not be confused with async keyword
ilevkivskyi-quora
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced asynq_to_async module but didn't add tests for mocks.
When using asynq with
.asyncioin conjunction with asynq.mock_.patch on an @asynq() decorated function, the.asyncioaccessor leads to a a MagicMock and can't be awaitedThis fixes that and adds unit tests