Please do not use hard-coded string literals, use one provided in strings.xml.

thanks can fix that, there are items in the home_menu which should be converted as well

Hmm... there should not be. Android Studio shows them as string literals, but actually they are not.

Overall, you will have to redo this patch anyway. Don't put the menu here. "More translations" option should go to translations spinner in translation screen/mode, the one you see at the top when you have more than one translation are installed.

ah ok, i misunderstood that ignore my bottom comment. I can add it in there. jzk

hey so ive looked at this a bit, focusing on TranslationsSpinnerAdapter and PagerActivity. I'm running into issues finding a straightforward solution - the translation spinner has a checkbox dropdown item, and implementing another view to the dropdown such as TextView is non-trivial unless both items are added to a parent view. Additionally, since the spinner has checkboxes, an event listener for OnItemSelectedListener isn't being picked up if implemented in PagerActivity. Please let me know if you have some guidance on this. Thank you

I suppose one will have to build a custom adapter that can hold multiple types of items (checkbox and text, in this case).

this is where the custom adapter is being made. since SpinnerAdapter is a BaseAdapter, you can just override getViewTypeCount to return 2, and getItemViewType to return 0 except for the last row (the custom row you will add), in which case you'll return 1.

then, in getView, if getItemViewType is 1, show a different xml or just a TextView with "get more translations"

hmm, it appears Spinners don't allow for setting this on the later APIs. "Spinner overrides getViewTypeCount() on the Adapter associated with this view. Calling getItemViewType(int) on the object returned from getAdapter() will always return 0. Calling getViewTypeCount() will always return 1. On API LOLLIPOP and above, attempting to set an adapter with more than one view type will throw an IllegalArgumentException." -https://developer.android.com/reference/android/widget/Spinner.html#setAdapter(android.widget.SpinnerAdapter) also https://code.google.com/p/android/issues/detail?id=17128. It looks like there can be a workaround using Tags however which I can look at

I actually have something working, will push later today - overrode getDropDownView as well

List<String> transList = Arrays.asList(translationName);

I tried this, getting java.lang.UnsupportedOperationException on the next line however when trying to add to the list. Is there another way you intended to do this? jzk

ah, makes sense, because Arrays.asList generates an immutable list.

i'd then replace it with a loop - i.e.

List<String> transList = new ArrayList<>();
for (String translation : translationNames) {
   transList.add(translation);
}

add to strings.xml and use an R.string value

remove it, you don't need it

I did this initially as translationNames is also used in addAll(translationNames);, should "More translations" not be a part of the underlying array?

you have two options - one is to add it within the underlying array, and the other is to change the adapter to know that "count is always size + 1," and to know that "once you pass this element, the next element is the more option" - if it's cleaner to add it to the array (i.e. if the array is all Strings, as it seems to be), then it probably makes sense.

jzk, thanks for the clarification!

keep wrapped in null check, otherwise, we make a new one every time this is called

undo changes to this file, not needed.

remove, not needed

remove for now

i think you can probably remove this method altogether

nit, spacing

make sure SpinnerHolder lets you get access to the checkbox and then hide/show it

thanks, could you clarify this, I didn't need to change anything here after implementing your other comments. Jzk

Why do you need this string?

I was basing this off the pattern used for R.string.translations where it referenced <string name="translations">@string/prefs_translations</string>. Otherwise I would've just referenced the string directly. Please let me know if this isn't necessary

prefs_translations is used in the Settings, prefs_more_translations is not used and not needed. Please remove it.

will do thanks

Unnecessary empty line?

jzk, yea this doesn't match the other methods, removing

Nitpick: I don't like the trans prefix. Can you make it translationsList or (since, it is a local variable) simply list would also work.

jzk, made into translationsList

Ditto.

Unnecessary empty line.

Unnecessary empty line.

Looks like this is not used.

Unused import

Please make it private

Unused import.

Please remove transparentDrawable and use setButtonDrawable(null) instead.

Please remove this for loop and use List<String> translationsList = new ArrayList<>(Arrays.asList(translationNames)); instead.

jzk, I made the change to a loop based on @ahmedre earlier comment "i'd then replace it with a loop - i.e.

List transList = new ArrayList<>();
for (String translation : translationNames) {
transList.add(translation);
}" , Please let me know if the replacement is what we want as a final state. thanks

Please replaced the for loop with the code from previous comment.

ok sure, i had changed it based on Ahmeds comments but i can revert it to this

I see. Let's wait for him on this then. I wonder what's his reasoning for using a for loop.

ok sure thing, my only thought would be readability but ill leave the change out for now

Android Studio is complaining that 'The resource @drawable/abc_btn_check_material is marked as private in com.android.support:appcompat'. Can we change its visibility somehow (instead of setting to null or changing its transparency)?

hmm, im not sure how this would be done outside of using a drawable, is there a reason other than bloat to bring in the checkbox drawable resource into the project workspace?

That's something @ahmedre to decide :)

sounds good iA

i still wish we'd share the inflation instead of inflating a separate view

i can do this iA