Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix basmallah between repeats #3366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahmedre merged 1 commit into from
Sep 21, 2025
Merged

Fix basmallah between repeats #3366

ahmedre merged 1 commit into from
Sep 21, 2025

Conversation

@ahmedre
Copy link
Contributor

@ahmedre ahmedre commented Sep 21, 2025

Due to a migration bug when moving from MediaPlayer to ExoPlayer, the
timing updater was run while the basmallah was playing in between sura
transitions during repeat ranges, causing the basmallah to not play or
be cut off. This fixes it to not restart the timing updater for player
overrides (basmallah playbacks).

@ahmedre
Fix basmallah between repeats
1100c94 
Due to a migration bug when moving from MediaPlayer to ExoPlayer, the
timing updater was run while the basmallah was playing in between sura
transitions during repeat ranges, causing the basmallah to not play or
be cut off. This fixes it to not restart the timing updater for player
overrides (basmallah playbacks).
@github-actions
Copy link

github-actions bot commented Sep 21, 2025 

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │          compressed           │         uncompressed          
          ├───────────┬───────────┬───────┼───────────┬───────────┬───────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff  
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼───────
      dex │  25.6 MiB │  25.6 MiB │ +31 B │  78.2 MiB │  78.2 MiB │ +92 B 
     arsc │   2.1 MiB │   2.1 MiB │   0 B │   2.1 MiB │   2.1 MiB │   0 B 
 manifest │   6.1 KiB │   6.1 KiB │   0 B │  29.7 KiB │  29.7 KiB │   0 B 
      res │   1.8 MiB │   1.8 MiB │  -6 B │     2 MiB │     2 MiB │   0 B 
   native │  18.8 KiB │  18.8 KiB │   0 B │  36.5 KiB │  36.5 KiB │   0 B 
    asset │ 452.1 KiB │ 452.1 KiB │   0 B │ 808.2 KiB │ 808.2 KiB │   0 B 
    other │ 198.3 KiB │ 198.3 KiB │  -1 B │ 495.1 KiB │ 495.1 KiB │   0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼───────
    total │  30.1 MiB │  30.1 MiB │ +24 B │  83.6 MiB │  83.6 MiB │ +92 B

@ahmedre ahmedre added this pull request to the merge queue Sep 21, 2025
Merged via the queue into main with commit 0a7d03e Sep 21, 2025
2 checks passed
@ahmedre ahmedre deleted the fix_basmallah_repeat branch September 21, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ahmedre