Job Status Support for CUPS #747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/qz/printer/status/job/CupsJobStatusMap.java
tresf
reviewed
Feb 8, 2021
tresf
reviewed
Feb 8, 2021
tresf
reviewed
Feb 8, 2021
tresf
reviewed
Feb 8, 2021
tresf
reviewed
Feb 8, 2021
tresf
reviewed
Feb 8, 2021
|
@Vzor- this looks to be in great shape. From what I understand, CUPS is firing some duplicate events. I think once that's sorted, we can merge. |
|
So it turns out the timing of things is causing hurdles. Specifically, the JNA calls are too late and don't have the status at the exact time of the RSS notification. We'll need to rework this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review.
Currently have an issue with redundant job statuses. Should we track the last status for every job?Windows + Mac Tested
Still needs testing on ubuntu