Fix a deadlock with printer status threading #1181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vzor-
commented
Sep 27, 2023
tresf
reviewed
Oct 2, 2023
|
Testing:
|
emkah4
pushed a commit
to Fourbolts/orderkrab-tray
that referenced
this pull request
May 24, 2025
Fix thread deadlock Related qzind#1116, qzind#1124 Co-authored-by: Tres Finocchiaro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a deadlock discovered while testing #1116. It should also alleviate the slowdown to a degree, though not as much as the JDK fix that is in the works, or the caching in #1124.
I still need to run some test, but this is the threading part of #1124 with the caching removed. The two features are a bit too disparate to exist in a PR together.