resolution for Not able to override step.provider.pkg property for data driven scenario#155
Open
infoneershalin wants to merge 5 commits intoqaf-tm:masterfrom
Open
resolution for Not able to override step.provider.pkg property for data driven scenario#155infoneershalin wants to merge 5 commits intoqaf-tm:masterfrom
infoneershalin wants to merge 5 commits intoqaf-tm:masterfrom
Conversation
added 5 commits
July 27, 2017 20:21
…e fileName is different.
Author
|
Will add Unit Testcases soon. |
infoneershalin
commented
Nov 28, 2017
Author
infoneershalin
left a comment
There was a problem hiding this comment.
@cjayswal please review this Pull request
Contributor
|
Did you understand the issue? Please share the test case. I am afraid that solution will have impact on performance. |
Author
|
Yes, DataDrivenScenario.java creates proxy steps and pass it to execute method of Scenario.java |
Contributor
|
You can check by commenting step initialization to have lazy initialization in DD scenario |
Author
|
I have tried that.
It takes proper step but breaks data passing to step as context does not get set properly,henxe data passed through files is not accessible using ${args[0]}.
On 28-Nov-2017 11:04 PM, cjayswal <[email protected]> wrote:
You can check by commenting step initialization<https://github.com/qmetry/qaf/blob/1e70f23256cd813880011934fc7aded9380b8346/src/com/qmetry/qaf/automation/step/client/DataDrivenScenario.java#L183> to have lazy initialization in DD scenario
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#155 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ATpW8HW7I5IVbfL2bvAdHRQn4yn-P5REks5s7EQHgaJpZM4QtZBK>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolution for #154
we were using initStep only when step is not yet initiated.
we need to re init the step in case fileName is different as step.provider.pkg has changed