Locator description display in report #197
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjayswal
reviewed
Jun 25, 2018
| private String getParam(String text) { | ||
| String result = getBundle().getSubstitutor().replace(text); | ||
| ParamType ptype = ParamType.getType(result); | ||
| String value = String.valueOf(getBundle().getObject(result)); |
Contributor
There was a problem hiding this comment.
@NightFox7, Thanks for the pull request
This possibly cause issues if
- value may be null if property not exist! use default value to overcome that situation of possible
NullPointerExceptionString value = getBundle().getString(result, result);
- value with key exist but argument referenced is not a locator or not parameter
- need to keep in mind that not all steps are element step, listener will be called by all steps. So possibly case where it points to string and not locator.
Collaborator
There was a problem hiding this comment.
Agree. We also need to consider below testcase also
<root>
<user>
<valid>
<username>amit</username>
<password>amitpwd</password>
</valid>
</user>
</root>BDD
When user login with 'user.valid'
@QAFTestStep(description="user login with {key}")
public void login(String key){
LoginBean bean = new LoginBean();
bean.fillFromConfig(key);
//To-Do
}@cjayswal I think actual root cause of this problem is StringTestStep#81. If we remove that line that #65 should work and #64 will also be resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locator description should be displayed in report instead of key (#65)
based on (#68)