Conversation
There was a problem hiding this comment.
Pull request overview
This pull request fixes callback handling issues and adds hardlink/symlink support to Krokiet.
Changes:
- Fixed multiple callback registrations by moving callback setup from individual connect functions to centralized connect_tab_changed
- Implemented hardlink and symlink functionality through a new ProcessFunction enum that supports both simple (single-item) and related (pair-item) operations
- Renamed MainListModel to SingleMainListModel for clarity and updated the logo
Reviewed changes
Copilot reviewed 40 out of 48 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| misc/find_unused_callbacks.py | New Python script to detect unused or multiple callback registrations |
| krokiet/ui/*.slint | Type rename MainListModel -> SingleMainListModel, removed unused callbacks, adjusted UI sizing |
| krokiet/src/model_operations/model_processor.rs | Added ProcessFunction enum to support both simple and related operations (hardlink/symlink) |
| krokiet/src/file_actions/connect_hardlink.rs | Implemented hardlink functionality using ProcessFunction::Related |
| krokiet/src/file_actions/connect_symlink.rs | Implemented symlink functionality using ProcessFunction::Related |
| krokiet/src/connect_tab_changed.rs | New file centralizing callback registration to prevent duplicates |
| krokiet/src/connect_sort.rs | Moved sort button setup out of callback to prevent multiple registrations |
| krokiet/src/connect_select.rs | Moved select button setup out of callback to prevent multiple registrations |
| czkawka_core/src/tools/video_optimizer/core.rs | Fixed thumbnail generation progress reporting and error collection |
| czkawka_core/src/tools/bad_names/core.rs | Reordered space trimming to run after other transformations |
| krokiet/icons/*.svg | Updated logo design |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 59 out of 67 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 61 out of 69 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kimberxu
pushed a commit
to kimberxu/czkawka
that referenced
this pull request
Jan 31, 2026
…added to cli new modes (qarmin#1760)
kimberxu
pushed a commit
to kimberxu/czkawka
that referenced
this pull request
Jan 31, 2026
…added to cli new modes (qarmin#1760)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1514