fix DigitPlaceholder, put a space for insignificant zeros #2216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y package `golang.org/x/crypto` (qax-os#2214) - Speedup UTF16 string length count, back port countUTF16String function from PR 2206 - Update dependencies modules - Update docs for the AddChart function
|
Performance improvements due to delayed conversion of fraction to strings goos: linux
goarch: amd64
pkg: github.com/xuri/excelize/v2
cpu: 12th Gen Intel(R) Core(TM) i5-12400F
BenchmarkNumFmtPlaceHolder
new code:
BenchmarkNumFmtPlaceHolder-12 1597 2256717 ns/op 2068054 B/op 75940 allocs/op
old code:
BenchmarkNumFmtPlaceHolder-12 997 3558671 ns/op 2308233 B/op 135981 allocs/op``` |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2216 +/- ##
=======================================
Coverage 99.24% 99.24%
=======================================
Files 32 32
Lines 30730 30761 +31
=======================================
+ Hits 30499 30530 +31
Misses 153 153
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b530856 to
28a977a
Compare
xuri
approved these changes
Oct 5, 2025
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
fix format '?' not filling enough spaces.
Partial test case results are inconsistent with Microsoft 365 results.
Related Issue
#2080
Motivation and Context
How Has This Been Tested
This has been tested in the unit test and with an actual file.
Types of changes
Checklist