optimize: convert using continued fractions fundamental recurrence formulas #2220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2220 +/- ##
=======================================
Coverage 99.34% 99.34%
=======================================
Files 32 32
Lines 25614 25616 +2
=======================================
+ Hits 25447 25449 +2
Misses 89 89
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xuri
requested changes
Nov 10, 2025
Member
xuri
left a comment
There was a problem hiding this comment.
Thanks for your PR. I've left some comments.
xuri
approved these changes
Nov 10, 2025
Member
xuri
left a comment
There was a problem hiding this comment.
LGTM. Thanks for your contribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Use
fundamental recursion formulasto avoid duplicate calculations.Formula reference: https://en.wikipedia.org/wiki/Continued_fraction#Fundamental_recurrence_formulas, https://oi-wiki.org/math/number-theory/continued-fraction/#%E9%80%92%E6%8E%A8%E5%85%B3%E7%B3%BB
Description
Related Issue
Motivation and Context
benchmark:
old:
BenchmarkNumFmtPlaceHolder-12 410 2789684 ns/op 2068222 B/op 75930 allocs/op
new:
BenchmarkNumFmtPlaceHolder-12 47521 26230 ns/op 11782 B/op 374 allocs/op
How Has This Been Tested
Types of changes
Checklist