feat: Add predefined DRAG driven control #183
Conversation
|
Just a note: I think after this is implemented, some refactoring might be appropriate to reduce code duplication in the now three existing driven controls which utilize Gaussians. |
Co-authored-by: Per Liebermann <[email protected]>
Co-authored-by: Per Liebermann <[email protected]>
Co-authored-by: Per Liebermann <[email protected]>
Co-authored-by: Per Liebermann <[email protected]>
tachikoma-li
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
Implementation looks good to me. Just leave some questions for discussion.
There was a problem hiding this comment.
@tiborr, really nice work! (just a minor inputs suggestion from me).
Co-authored-by: Viktor Perunicic <[email protected]>
There was a problem hiding this comment.
Great work!
I'll merge it later once @perjlieb and @ViktorPerunicic are both happy with it.
ViktorPerunicic
left a comment
There was a problem hiding this comment.
Looks good to me @tiborr, nice work :)
Have you had a chance to try out using this and/or the Gaussian pulse in BOULDER OPAL yet?
Thanks! That's a great idea, I'll see how they do. |
Changes proposed in this pull request: