Update block_data.py #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was getting 2CHN instead of final absorbance (AB), so with some trial and error to the block_data I got absorbance for three different instruments.
|
Thanks for this work. Could you please explain the conditions that guarantee correct absorbance values, even when using different instruments. ? Why must self.channel_type be equal to 16, and what does the value 1332 represent for self.chunk_size ? |
|
I wish I knew! I've not found any documentation for this code that explains. These were the conditions that gave the same absorbance results as values exported from Opus. I cannot guarantee that it will work for all instruments and settings, but it is what worked for us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was getting 2CHN instead of final absorbance (AB), so with some trial and error to the block_data I got absorbance for three different instruments.