[#2] Implement RGB parsing from hex #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qexat
approved these changes
Feb 2, 2025
Owner
qexat
left a comment
There was a problem hiding this comment.
Thank you for the PR!
I have nothing to add, great job as usual ♡
qexat
added a commit
that referenced
this pull request
Feb 3, 2025
# 0.2.0 ## Features - Add color functions `luminance` and `best_for_contrast`. (by @chshersh in #5) - Add styling functions `fg`, `bg`, `bold`, `dim`, `italic`, `underlined`. (by @chshersh in #6) - Add styling composition with `&`. (by @chshersh in #6) - Add function `make_rgb_hex` to parse hexadecimal codes into RGB colors. (by @chshersh in #7) ## Breaking Changes - `Color.t` and `Color.Ground.t` are now polymorphic variants. (by @chshersh in #5) ## Removed - `Util.parenthesize_if` which is deemed unuseful and is kind of a duplicate of `Tree.parenthesize_if` in `Formatting`.
qexat
added a commit
to qexat/opam-repository
that referenced
this pull request
Feb 3, 2025
CHANGES: ## Features - Add color functions `luminance` and `best_for_contrast`. (by @chshersh in qexat/ansifmt#5) - Add styling functions `fg`, `bg`, `bold`, `dim`, `italic`, `underlined`. (by @chshersh in qexat/ansifmt#6) - Add styling composition with `&`. (by @chshersh in qexat/ansifmt#6) - Add function `make_rgb_hex` to parse hexadecimal codes into RGB colors. (by @chshersh in qexat/ansifmt#7) ## Breaking Changes - `Color.t` and `Color.Ground.t` are now polymorphic variants. (by @chshersh in qexat/ansifmt#5) ## Removed - `Util.parenthesize_if` which is deemed unuseful and is kind of a duplicate of `Tree.parenthesize_if` in `Formatting`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2
Added a function to parse the RGB constructor from a hex color string.
A few notes:
optioninstead of a more detailed error. I'm not a fan of exceptions and since there could be too many possibilities to fail, I decided that a detailed error message is not needed.Happy to make any changes!
Checked in
utopthat it works: