-
-
Notifications
You must be signed in to change notification settings - Fork 169
Geocoding with autocompletion #1151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
For autocomplete, please read this discussion and let me know your thoughts. If I’m not mistaken, the OSM Foundation prohibits using autocomplete with Nominatim. I look forward to your feedback and thank you for the commit. |
|
You're right. I quote the Nominatim Usage Policy
The fact is I need this version with the BAN for a personal project. I keep this version for my teamwork. |
|
I am coming back to you again because I see one think on the leaflet.photon documentation. There is an argument |
|
This can solve the situation perfectly, do you have time to prepare a definitive master so I can try it? |
|
Yes, I don't think it's complicated. Just to change 300 to 1000 |
|
Normally, all is ok. You can try it on your side. |
|
I have corrected some bugs: the display of the search bar on the left-container and the popup display. Does the display of the labels is normal? |
|
I will work on the rest the next week |
|
I have made some correction for the display. It's seem correct. I let you try it on your side. |
|
I have test on firefox and Chrome (with a laptop) and icons seem centered, no artefact(no more scroll bar), english in the placeholder. |
|
I'm using your master and export a Leaflet map. I am attaching the export. |
|
I have correct it. I have change the place of the css in the python script. It was in a condition that applied only if the layer list was collapsed. I have also corrected the display of an icon that didn't appear if the search bar address was on "None". |
Hi,
In this fork, I have made some changes for the address search bar. I have used the photon library as a base.
I allow the user to select the service of geocoding. For the moment, the user can select nominatim or the BAN (address database in France) as service. Moreover, I have added the autocompletion by default.
As written on the documentation, I have implemented this in the both (leaflet, openlayers).
I am open for the suggestions to improve and maybe merge this code to the main branch.
Best regards