fix: exit successfully when catch specific signal#173
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CarlJi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @lyyyuna |
Codecov Report
@@ Coverage Diff @@
## master #173 +/- ##
==========================================
+ Coverage 67.77% 68.00% +0.23%
==========================================
Files 34 34
Lines 1738 1738
==========================================
+ Hits 1178 1182 +4
+ Misses 454 451 -3
+ Partials 106 105 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
注意到我们有自己的 signal notify,这种行为会导致用户原有的一些退出逻辑被破坏: signal handler 目前我想到的分两种情况:
这部分有必要重新设计。 |
|
@lyyyuna 出个方案,我们一起讨论下。 |
|
看起来没有更好的方案,先合并以修复问题。 |
fix #171