-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix base url not being passed through github_provider class correctly #1127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
|
thanks, i will review it later today |
|
@squinn1 Run the code, catch breakpoints, and test is. |
|
Hi @mrT23, Thanks |
|
yes, this was the problem, the 'https' |
User description
all unit tests passing
PR Type
Bug fix, Enhancement
Description
base_urlandbase_url_htmlattributes were not being correctly used throughout theGitHubProviderclass._parse_pr_urland_parse_issue_urlmethods from static to instance methods to accessself.base_url.get_lines_link_original_filemethod to useself.base_url_htmlinstead of hardcoded 'github.com'.Changes walkthrough 📝
github_provider.py
Refactor GitHub provider to use instance-specific base URLspr_agent/git_providers/github_provider.py
_parse_pr_urland_parse_issue_urlself.base_urlinstead of hardcoded'api.github.com'
get_lines_link_original_fileto useself.base_url_htmlinstead of hardcoded 'github.com'