Work with minitest 5.19+ #108
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minitest 5.19 broke backwards compatibility and removed the Minitest::Unit::VERSION constant. This uses the Minitest::VERSION constant if the Minitest::Unit::VERSION constant is not available.
dentarg
added a commit
to Starkast/wikimum
that referenced
this pull request
Aug 17, 2023
Minitest was updated in b311f5e and 5.19 introduced the breaking change minitest/minitest@a2c6c18 explained in minitest/minitest@96a9972 There's qrush/m#108 that would make this change unnecessary
|
Work around is to set |
|
Ping |
|
Looks like this was fixed in fa26cd8. Updating to the latest 1.6.2+ gem version fixes the issue, this PR can be closed. |
|
For the benefit of anyone searching for the error text: (I confirm that updating to v1.6.2 fixes it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minitest 5.19 broke backwards compatibility and removed the Minitest::Unit::VERSION constant. This uses the Minitest::VERSION constant if the Minitest::Unit::VERSION constant is not available.