RPP handle mem leaks Fix#475
Merged
r-abishek merged 1 commit intor-abishek:ar/bugfix_handlefrom Aug 20, 2025
Merged
Conversation
r-abishek
approved these changes
Aug 20, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes memory leaks in the RPP (ROCm Performance Primitives) library by properly deallocating handle objects and their internal implementation pointers. The changes ensure that both the internal handle implementation and the handle object itself are properly cleaned up during destruction.
- Adds proper cleanup of internal handle implementation pointer in destroy functions
- Modifies the public API to delete the handle object after cleanup
- Ensures consistent cleanup behavior across different backend types
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/modules/handle_host.cpp | Adds deletion of internal handle and nullifies implementation pointer |
| src/modules/handle_hip.cpp | Adds deletion of internal handle and nullifies implementation pointer |
| src/modules/handle_api.cpp | Modifies public API to delete handle object and return success status directly |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.