Mem copy elimination#496
Conversation
… rcm, color temperature
There was a problem hiding this comment.
Pull Request Overview
This PR eliminates memory copy operations and migrates to hipHostMalloc for GPU-accessible memory allocation across multiple image processing kernels. The changes optimize performance by eliminating host-to-device memory transfers for kernel parameters.
- Replaces static arrays with
hipHostMallocallocations for kernel parameters - Removes dependency on internal handle memory management (
copy_param_*functions) - Adds direct parameter passing to kernel execution functions instead of using cached memory
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| utilities/test_suite/HIP/Tensor_image_hip.cpp | Replaces stack arrays with hipHostMalloc for tensor parameters and adds memory cleanup |
| src/modules/tensor/rppt_tensor_*.cpp | Removes copy_param_* calls and passes tensors directly to kernel executors |
| src/modules/tensor/hip/kernel/*.cpp | Updates kernel executors to accept tensor parameters directly instead of using handle memory |
| src/include/tensor/hip_tensor_executors.hpp | Updates function signatures to include tensor parameters |
| docs/sphinx/requirements.* | Updates rocm-docs-core version dependency |
Comments suppressed due to low confidence (2)
src/modules/tensor/hip/kernel/color_twist.cpp:1
- Incorrect data type allocation:
contrastshould be allocated asRpp32fbut is being allocated asRpptRGB. This will cause memory layout issues.
/*
src/modules/tensor/hip/kernel/color_twist.cpp:1
- Incorrect data type allocation:
saturationshould be allocated asRpp32fbut is being allocated asRpptRGB. This will cause memory layout issues.
/*
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if(additionalParam == 0) | ||
| { | ||
| CHECK_RETURN_STATUS(hipHostMalloc(&noiseProbabilityTensor, batchSize * sizeof(Rpp32f))); | ||
| CHECK_RETURN_STATUS(hipHostMalloc(&saltProbabilityTensor, batchSize * sizeof(RpptRGB))); |
There was a problem hiding this comment.
Incorrect data type allocation: saltProbabilityTensor should be allocated as Rpp32f but is being allocated as RpptRGB. This will cause memory layout issues.
| CHECK_RETURN_STATUS(hipHostMalloc(&saltProbabilityTensor, batchSize * sizeof(RpptRGB))); | |
| CHECK_RETURN_STATUS(hipHostMalloc(&saltProbabilityTensor, batchSize * sizeof(Rpp32f))); |
| CHECK_RETURN_STATUS(hipHostMalloc(&noiseProbabilityTensor, batchSize * sizeof(Rpp32f))); | ||
| CHECK_RETURN_STATUS(hipHostMalloc(&saltProbabilityTensor, batchSize * sizeof(RpptRGB))); | ||
| CHECK_RETURN_STATUS(hipHostMalloc(&saltValueTensor, batchSize * sizeof(Rpp32f))); | ||
| CHECK_RETURN_STATUS(hipHostMalloc(&pepperValueTensor, batchSize * sizeof(RpptRGB))); |
There was a problem hiding this comment.
Incorrect data type allocation: pepperValueTensor should be allocated as Rpp32f but is being allocated as RpptRGB. This will cause memory layout issues.
| CHECK_RETURN_STATUS(hipHostMalloc(&pepperValueTensor, batchSize * sizeof(RpptRGB))); | |
| CHECK_RETURN_STATUS(hipHostMalloc(&pepperValueTensor, batchSize * sizeof(Rpp32f))); |
| } | ||
| if(stdDevTensor != NULL) | ||
| CHECK_RETURN_STATUS(hipHostFree(stdDevTensor)); | ||
| if(meanTensor != NULL) | ||
| CHECK_RETURN_STATUS(hipHostFree(meanTensor)); |
There was a problem hiding this comment.
Missing memory cleanup for meanTensor and stdDevTensor when additionalParam == 1 in the NOISE case. These allocations are made at lines 524-525 but not freed in the cleanup section.
| } | |
| if(stdDevTensor != NULL) | |
| CHECK_RETURN_STATUS(hipHostFree(stdDevTensor)); | |
| if(meanTensor != NULL) | |
| CHECK_RETURN_STATUS(hipHostFree(meanTensor)); | |
| else if(additionalParam == 1) | |
| { | |
| if(stdDevTensor != NULL) | |
| CHECK_RETURN_STATUS(hipHostFree(stdDevTensor)); | |
| if(meanTensor != NULL) | |
| CHECK_RETURN_STATUS(hipHostFree(meanTensor)); | |
| } | |
| } |
There was a problem hiding this comment.
Memory for stdDevTensor and meanTensor was done outside the noise to make it common and avoid double usage of free. This comment can be ignored
|
@r-abishek Made all required modifications and tested - ready for review |
r-abishek
left a comment
There was a problem hiding this comment.
@RooseweltMcW Pls check the comment
| @@ -1817,24 +1817,16 @@ RppStatus rppt_crop_mirror_normalize_gpu(RppPtr_t srcPtr, | |||
| { | |||
| #ifdef HIP_COMPILE | |||
| Rpp32u paramIndex = 0; | |||
* Docs - Bump rocm-docs-core[api_reference] from 1.10.0 to 1.11.0 in /docs/sphinx (r-abishek#487) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.10.0 to 1.11.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.10.0...v1.11.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * RPP Fog augmentation on HOST and HIP (r-abishek#446) * adds Fog tensor support * modified comments minor fix in HIP kernel * changed c style casting to static_cast inside HIP kernel modified few variable names * added note in documentation added fog test case to randomOutputCase in HIP and HOST test suites * Introduced Greyness factor on Host FOG Kernel * Introduced Greyness factor on HIP Side * Added Grey scale support for Raw C code and PLN3 variant * Modified Converstion factor variable * Doxygen Outputs changed * Variable name changes * Changes in HUe Saturation Matrix * Fix output issue * Update CHANGELOG.md Co-authored-by: spolifroni-amd <[email protected]> * Updates to 1.9.10 including fog feature --------- Co-authored-by: sampath1117 <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: Lakshmi Kumar <[email protected]> Co-authored-by: Rajy Rawther <[email protected]> Co-authored-by: spolifroni-amd <[email protected]> Co-authored-by: Srihari-mcw <[email protected]> * RPP Warp Perspective on HOST and HIP (r-abishek#451) * Make initial changes for raw CPP version of warp perspective * Fix calls to compute_warp_perspective_src_loc function * Update changes to go through nearest neighbours case * AVX HOST codes for warp perspective initial * Fixes for accuracy in warp perspective * More fixes for accuracy in warp perspective * Update the cide for AVX version of Planar to Planar * Add bilinear u8 host code for warp perspective * Make updates to include functions for F32 data type * Make updates to use cast instead of set and fix issues with raw C implementation * Add i8 host codes * Add updates for F16 Bilinear Code * Update the initial HIP code for warp perspective * Update fixes for HIP code * Add Warp Perspective Nearest Neighbors F16 code for PKD3_to_PLN3 and PLN3_to_PLN3 * Add updates for PLN to PLN configuration * Add updates for PKD3 to PKD3 case * Rename variables * Update changes to log images separately for Bilinear and Nearest Neighbors * fixed bug in raw c code of PKD-PLN variant * minor bug fix for F16 PLN variants * minor fixes in HOST test suite * Update the HIP code for review comments and refactoring of device functions * Update the comments alignment * Rename functions and add cases in HOST and HIP runTests.py * Update indentations for compuatations and rename vectors * Update documentations and add more reference variables * Make more formatting changes * Make further updates by including test cases * Make updates to use reinterpret cast * Update reinterpret casts for PLN to PLN configuration u8 and i8 codes * Make updates to enclose code inside AVX2 flag * Make further changes to update type casting * Update the version * Make updates to add warp perspective image * Modify comments, update CHANGELOG and update flags * Update further comments in warp perspective * Add more comments for warp perspective * Update based on further review comments * Update the case number for warp_perspective in common.py * Address review comments * Make initial changes for raw CPP version of warp perspective * Fix calls to compute_warp_perspective_src_loc function * Update changes to go through nearest neighbours case * AVX HOST codes for warp perspective initial * Fixes for accuracy in warp perspective * More fixes for accuracy in warp perspective * Update the cide for AVX version of Planar to Planar * Add bilinear u8 host code for warp perspective * Make updates to include functions for F32 data type * Make updates to use cast instead of set and fix issues with raw C implementation * Add i8 host codes * Add updates for F16 Bilinear Code * Update the initial HIP code for warp perspective * Update fixes for HIP code * Add Warp Perspective Nearest Neighbors F16 code for PKD3_to_PLN3 and PLN3_to_PLN3 * Add updates for PLN to PLN configuration * Add updates for PKD3 to PKD3 case * Rename variables * Update changes to log images separately for Bilinear and Nearest Neighbors * fixed bug in raw c code of PKD-PLN variant * minor bug fix for F16 PLN variants * minor fixes in HOST test suite * Update the HIP code for review comments and refactoring of device functions * Update the comments alignment * Rename functions and add cases in HOST and HIP runTests.py * Update indentations for compuatations and rename vectors * Update documentations and add more reference variables * Make more formatting changes * Make further updates by including test cases * Make updates to use reinterpret cast * Update reinterpret casts for PLN to PLN configuration u8 and i8 codes * Make updates to enclose code inside AVX2 flag * Make further changes to update type casting * Make updates to add warp perspective image * Modify comments, update CHANGELOG and update flags * Update further comments in warp perspective * Add more comments for warp perspective * Update based on further review comments * Update the case number for warp_perspective in common.py * Address review comments * Fix conflits with warp perspective * Update version details * Merge branch 'ar/opt_warp_perspective' of https://github.com/r-abishek/rpp into opt_warp_perspective_rebased * Update version to 1.9.10 including warp perspective * Updates to convert to XYWH from LTRB instead of opposite * Update CHANGELOG.md Co-authored-by: spolifroni-amd <[email protected]> * Revert changes and convert to ltrb instead of xywh --------- Co-authored-by: Srihari-mcw <[email protected]> Co-authored-by: sampath1117 <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> Co-authored-by: Rajy Rawther <[email protected]> Co-authored-by: spolifroni-amd <[email protected]> * Package - Updates and bugfixes (r-abishek#488) * Package - remove clang from test * CMakeLists - remove BUILD_WITH_AMD_ADVANCE * Package - Add OMP dependency * Find Packages - Updates * Test Package - Deps * Test - backend Info * Tests - Fix HIP Test Add * Test - Add HIP Path * Test - Find HIP Updates * Tests - Fix HIP compilation * Jenkins - Fix Test (r-abishek#489) * Jenkins - Fix Test * Test - Create sepreate test folder * FileSystem - Find and process * Find Filesystem - Updates * Test - Compiler Updates * Docs - Bump rocm-docs-core[api_reference] from 1.11.0 to 1.12.0 in /docs/sphinx (r-abishek#491) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.11.0 to 1.12.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.11.0...v1.12.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Docs - Bump rocm-docs-core[api_reference] from 1.12.0 to 1.12.1 in /docs/sphinx (r-abishek#495) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.12.0 to 1.12.1. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.12.0...v1.12.1) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Updates and Fixes - Compiler & Libs (r-abishek#493) * Test Suite - Fix HIP Link * Tests - HIP Updates * Test - Link OpenCV * Test - Link dir updates * CMakeLists - Updates * Test Package - Deps * CXX Compiler & ROCm path updates * ROCm Path - Display info * OpenMP - Updates * Package Deps - Remove OpenMP * jpeg * Compiler updates - C++ 14 Removal (r-abishek#496) * pthread removal * c++14 removal --------- Co-authored-by: Kiriti Gowda <[email protected]> * Docs - Bump rocm-docs-core[api_reference] from 1.12.1 to 1.13.0 in /docs/sphinx (r-abishek#500) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.12.1 to 1.13.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.12.1...v1.13.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * zigzag ordering * zigzag ordering * Compiler updates - C++ 14 Removal (r-abishek#496) * pthread removal * c++14 removal --------- Co-authored-by: Kiriti Gowda <[email protected]> * Readme & Package - Updates (r-abishek#503) * Readme - Updates * Package - Deps to OpenMP * Tests - Rename tensor tests for clarity (r-abishek#469) * Rename Tensor_host to Tensor_image_host, and runTests to runImageTests * Rename Tensor_hip to Tensor_image_hip, and runTests to runImageTests * Rename all readme runTests.py to runImageTests.py --------- Co-authored-by: Kiriti Gowda <[email protected]> Co-authored-by: Srihari-mcw <[email protected]> * minor changes * Tests - Rename tensor tests for clarity (r-abishek#469) * Rename Tensor_host to Tensor_image_host, and runTests to runImageTests * Rename Tensor_hip to Tensor_image_hip, and runTests to runImageTests * Rename all readme runTests.py to runImageTests.py --------- Co-authored-by: Kiriti Gowda <[email protected]> Co-authored-by: Srihari-mcw <[email protected]> * RPP Threshold - HOST and HIP implementation (r-abishek#456) * added initial support for U8 PLN1-PLN1 variant * added support for U8 PKD3, PLN3 variants * modified algorithm to give RGB output for RGB images * moved common code outside the layout branch conditions * added support for toggle variation of U8 * added golden output for threshold * added threshold output for doxygen * added support for F32 bit depth * added support for I8 bitdepth * added F16 bitdepth support * added HIP support for U8 bitdepth * made changes to support remaining bitdepths * fixed output issues with I8 variant * removed commented code in HOST * added threshold test case in maps used in common.py * modified RPP_VERSION_MINOR value and changelog * fixed issues with doxygen modified globalThreads_x value for HIP kernel * made changes in I8 variants as per review comments * added more details for threshold documentation * Update version to 1.9.10 including threshold * Remove duplicate definitions of functions and minor bug fix * Minor docs fix * Minor docs fix --------- Co-authored-by: sampath1117 <[email protected]> Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> Co-authored-by: Srihari-mcw <[email protected]> * RPP Rain augmentation - HOST and HIP implementation (r-abishek#463) * Add Intial u8 implementation for Rain * Add I8 implementation and Changes based on the Review comments * Initial HIP implementation Add F32 and F16 Tensor Implementation * Add test case for Rain in HIP test suite code cleanup * minor code cleanup * Modified func names and removed unnecessary code * Resolve Review comments * replaced pinned memory with HIP memory for Rain Layer computation * Modified RGB Rain Mask to planar Rain Mask in HIP * Address review comments * Add Rain compute function * Add version changes and Resolve review comments * fix build warnings * Fix the outputs of f16 toggle variants * Revert Rain width changes * Fix pln3 outputs for u8 and i8 bitdepths * Resolve review comments * Modified load and store routines for planar cases * Resolve review comments * Modify docs image * Fix versioning * Updates to 1.9.10 including rain feature --------- Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> Co-authored-by: Srihari-mcw <[email protected]> * Docs - Created a more comprehensive installation from the readme information (r-abishek#504) Co-authored-by: Kiriti Gowda <[email protected]> * Test suite build fix - Lock to specific 'nifti_clib' commit (r-abishek#506) * Lock nifti_clib commit in readme * Lock nifti_clib commit in common.groovy * Change to sudo apt install half in common.groovy * Debugging stage * Test Package - Updates (r-abishek#507) * Test suite - Error code detection and display (r-abishek#483) * experimental changes to detect error and print in the end in image test suite * Error handling added for host side * Error detection implemented on HIP SIDE * Voxel test suite changes * Changed variable name to camelCase * Changes in srcpath * Changes in Voxel test suite for nonQA case * Consolidated the repeated code and move it as common code * Minor changes based on review commands * Modification for bitDepth in voxel host * Merge with develop branch * Fix on error code display and gaussian Filter * F string bug is resolved * Fix for CI failure and some improvement in error detection * Changes based on review comments * Fix for rain and warp_perspective issue of unable to open file * Enhanced display for non implimented functionality --------- Co-authored-by: sampath1117 <[email protected]> Co-authored-by: dineshbabu-ravichandran <[email protected]> Co-authored-by: dineshbabu-ravichandran <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> Co-authored-by: HazarathKumarM <[email protected]> * Test Suite - ENUMs for all augmentations to enhance test suite readability (r-abishek#499) * initial commit * removed the usage of supported case list on HOST backend * Add Augmentation enum * removed supported caselists from all the python scripts in HIP backend * replacing case numbers with the enum's on the test suite files * Fix Indentation * Add enums for the swith cases * update Enum's for new cases * Fix errors in unit tests * Semicolon typo fix * Fix the test case naming in QA mode * removes unncessary print statements --------- Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> * OpenMP - Updates (r-abishek#510) * Update common.groovy * Fixes for Segmentation fault * Docs - Bump rocm-docs-core[api_reference] from 1.13.0 to 1.14.1 in /docs/sphinx (r-abishek#511) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.13.0 to 1.14.1. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.13.0...v1.14.1) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Test - Change sprintf to snprintf (r-abishek#512) Co-authored-by: Kiriti Gowda <[email protected]> * Jpeg PKD3 to PKD3 till DCT INV * RPP Bitwise - XOR on HOST and HIP (r-abishek#464) * Update the initial CODE for HIP Implementation of Exclusive OR * Add exclusive_or.hpp hip file * Update the code for initial HOST Code * Make SSE based updatess for exclusive or * Update the code for AVX2 implementation of U8 code * Uncomment pragma * Initial commit for I8 * Add I8 case * Fix issues with PKD3 to PLN3 i8 implementation * Initial updates based on self review * More updates * More cleanup * Update separate code for PLN3 to PLN3 U8 * Update separate code for PLN3 to PLN3 I8 * Update separate code for PLN3 to PLN3 F32 * Fix compilation issues * Fix accuracy issues for PLN3 to PLN3 * Add comments and formatting * Rearrange the function declarations * Add golden outputs for exclusive or * Add AVX2 flags wherever necessary * Update the code to have updated F16 load functions * HIP Code Updates * F16 PLN3 to PLN3 Updates * Update outputs * Rearrange XOR GPU function header * Add empty line * Update aligned length * Updates to make F16 outputs consistent with other bit depths * Add std::nearbyintf in exclusive or hip code * Update the code to use predefined zero vectors * Update to use existing rpp_load96_u8_avx instead of rpp_load96_u8pln3_to_u8pln3 * Update the version * Update changelog * Update CHANGELOG.md * Updates to fix more merge conflicts * Update version to 1.9.10 including exclusive or * Remove duplicate definitions of functions * Updates to just have u8 version of exclusive OR * Fix issues with xor after changes * Update changes to rename exclusive OR to bitwise xor and retain U8 data type alone * Update test suite to have only U8 bit depth * Update test suite to have only U8 bit depth on HOST also * Update condition for data type check * Update condition again for data type check --------- Co-authored-by: Srihari-mcw <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> * Docs - miscellaneous changes (r-abishek#508) * added the image from whatis/readme to the front page * added back the misisng install file into the TOC * added a note about CPU being HOST; added audio functionality; modified the toc * added a reference file for the api that acts as the anchor for a sublist in the toc * Fixing problems with api ref links * Still trying to fix the problems with api ref links --------- Co-authored-by: Kiriti Gowda <[email protected]> * jpeg PKD3 to PKD3 with a little distortion * Docs - Bump rocm-docs-core[api_reference] from 1.14.1 to 1.15.0 in /docs/sphinx (r-abishek#515) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.14.1 to 1.15.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.14.1...v1.15.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Jpeg u8 all layouts * Jpeg all layouts U8, F32 * Jpeg Compression all variants in all layouts * Package - Updates for RPM (r-abishek#519) * JPEG Compression distortion * PKD3 PLN3 QA * Docs - Bump rocm-docs-core[api_reference] from 1.15.0 to 1.17.0 in /docs/sphinx (r-abishek#521) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.15.0 to 1.17.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.15.0...v1.17.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * CMakeLists - gfx updates (r-abishek#516) * gfx updates * rocm version check for targets * Use rocm_check_target_ids if available * move gfx942 to default list --------- Co-authored-by: Kiriti Gowda <[email protected]> Co-authored-by: Cordell Bloor <[email protected]> * RPP Restructure - Consolidate handle creation and destruction APIs (r-abishek#513) * Changed to rppcreateHost and rppCreateGPU * Added rppCreate for HOST and HIP * Completely removed RppCreateHOST and rppCreateHIP on BatchPD. * Destroy HOST and GPU is removed * Changes based on review comments * Separated thread and stream as a separate argument * Retained setStream api and related functions * Minor docs fix * Removed empty line * Update CHANGELOG.md * Update CHANGELOG.md version to 1.9.11 * Update CMakeLists.txt version to 1.9.11 * Update rpp_version.h version to 1.9.11 * Update CHANGELOG.md Co-authored-by: spolifroni-amd <[email protected]> * Update CHANGELOG.md Co-authored-by: spolifroni-amd <[email protected]> * Update CHANGELOG.md Co-authored-by: spolifroni-amd <[email protected]> * Update CHANGELOG.md Co-authored-by: spolifroni-amd <[email protected]> * Update CHANGELOG.md Co-authored-by: spolifroni-amd <[email protected]> * Update CHANGELOG.md Co-authored-by: spolifroni-amd <[email protected]> * Update CHANGELOG.md Co-authored-by: spolifroni-amd <[email protected]> * Update CHANGELOG.md Co-authored-by: spolifroni-amd <[email protected]> * Update CHANGELOG.md Co-authored-by: spolifroni-amd <[email protected]> * Update CHANGELOG.md for rppCreate and rpp Destroy * Update CHANGELOG.md Co-authored-by: spolifroni-amd <[email protected]> * Update CHANGELOG.md Co-authored-by: spolifroni-amd <[email protected]> * Update CHANGELOG.md Co-authored-by: spolifroni-amd <[email protected]> * Update CHANGELOG.md * Update CHANGELOG.md for RPP 2.0.0 * Update CMakeLists.txt for RPP 2.0.0 * Update rpp_version.h for RPP 2.0.0 --------- Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> Co-authored-by: spolifroni-amd <[email protected]> * RPP Tensor Support - Bitwise NOT, Bitwise AND, Bitwise OR (r-abishek#520) * Add Initial implementation of Bitwise NOT in HOST backend * Add HIP Implementation for Bitwise Not kernel * Add Bitwise NOT implementation for I8, F32 and F16 bitdepths * Fix output issues for float variants * code cleanup * Modify aligned Length for pln3-pln3 conversion * Modified the casting style and updated doc images * update augmentations maps in test suite * Changes for converting bitwise or and and into u8 bitdepth * Changes for solving build errors * bitwise and & or for u8 on HOST * Minor changes to resolve error due to merging * Limited only support for U8 * Renaming from logical to bitwise * Golden output file is added * Changes based on review comments * REmoved changes in host_logical_operationss.hpp * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> * Docs - Bump rocm-docs-core[api_reference] from 1.17.0 to 1.17.1 in /docs/sphinx (r-abishek#523) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.17.0 to 1.17.1. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.17.0...v1.17.1) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * RPP Test Suite - Bugfixes for Gaussian filter and QA test summary (r-abishek#524) * Fix the summary and fix the unit test issues of Gaussian filter * Fix performance tests summary table * fix unit test path * revert change * revert changes --------- Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> * compact code * corrections after merge * minor modification * minor modification * revert changes * cleanup the code * revert merge changes * cleanup the code * updated the doxygen comments and cleanup * resolve review comments * Fix review comments * resolve merge issues * resolve review comments * cleanup the code * Resolve review comments * Optimize dct fwd and inverse functions * resolve review comments * categorized the code * moved common code of all function * Add comments for load/store functions * Update license to 2025 * Update CHANGELOG.md * Fix docs Co-authored-by: Copilot <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sampath1117 <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: Lakshmi Kumar <[email protected]> Co-authored-by: Rajy Rawther <[email protected]> Co-authored-by: spolifroni-amd <[email protected]> Co-authored-by: Srihari-mcw <[email protected]> Co-authored-by: ManasaDattaT <[email protected]> Co-authored-by: Hansel Yang <[email protected]> Co-authored-by: dineshbabu-ravichandran <[email protected]> Co-authored-by: dineshbabu-ravichandran <[email protected]> Co-authored-by: root <[email protected]> Co-authored-by: Cordell Bloor <[email protected]> Co-authored-by: Copilot <[email protected]>
* pthread removal * c++14 removal --------- Co-authored-by: Kiriti Gowda <[email protected]>
* pthread removal * c++14 removal --------- Co-authored-by: Kiriti Gowda <[email protected]>
* Docs - Bump rocm-docs-core[api_reference] from 1.10.0 to 1.11.0 in /docs/sphinx (r-abishek#487) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.10.0 to 1.11.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.10.0...v1.11.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * RPP Fog augmentation on HOST and HIP (r-abishek#446) * adds Fog tensor support * modified comments minor fix in HIP kernel * changed c style casting to static_cast inside HIP kernel modified few variable names * added note in documentation added fog test case to randomOutputCase in HIP and HOST test suites * Introduced Greyness factor on Host FOG Kernel * Introduced Greyness factor on HIP Side * Added Grey scale support for Raw C code and PLN3 variant * Modified Converstion factor variable * Doxygen Outputs changed * Variable name changes * Changes in HUe Saturation Matrix * Fix output issue * Update CHANGELOG.md Co-authored-by: spolifroni-amd <[email protected]> * Updates to 1.9.10 including fog feature --------- Co-authored-by: sampath1117 <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: Lakshmi Kumar <[email protected]> Co-authored-by: Rajy Rawther <[email protected]> Co-authored-by: spolifroni-amd <[email protected]> Co-authored-by: Srihari-mcw <[email protected]> * RPP Warp Perspective on HOST and HIP (r-abishek#451) * Make initial changes for raw CPP version of warp perspective * Fix calls to compute_warp_perspective_src_loc function * Update changes to go through nearest neighbours case * AVX HOST codes for warp perspective initial * Fixes for accuracy in warp perspective * More fixes for accuracy in warp perspective * Update the cide for AVX version of Planar to Planar * Add bilinear u8 host code for warp perspective * Make updates to include functions for F32 data type * Make updates to use cast instead of set and fix issues with raw C implementation * Add i8 host codes * Add updates for F16 Bilinear Code * Update the initial HIP code for warp perspective * Update fixes for HIP code * Add Warp Perspective Nearest Neighbors F16 code for PKD3_to_PLN3 and PLN3_to_PLN3 * Add updates for PLN to PLN configuration * Add updates for PKD3 to PKD3 case * Rename variables * Update changes to log images separately for Bilinear and Nearest Neighbors * fixed bug in raw c code of PKD-PLN variant * minor bug fix for F16 PLN variants * minor fixes in HOST test suite * Update the HIP code for review comments and refactoring of device functions * Update the comments alignment * Rename functions and add cases in HOST and HIP runTests.py * Update indentations for compuatations and rename vectors * Update documentations and add more reference variables * Make more formatting changes * Make further updates by including test cases * Make updates to use reinterpret cast * Update reinterpret casts for PLN to PLN configuration u8 and i8 codes * Make updates to enclose code inside AVX2 flag * Make further changes to update type casting * Update the version * Make updates to add warp perspective image * Modify comments, update CHANGELOG and update flags * Update further comments in warp perspective * Add more comments for warp perspective * Update based on further review comments * Update the case number for warp_perspective in common.py * Address review comments * Make initial changes for raw CPP version of warp perspective * Fix calls to compute_warp_perspective_src_loc function * Update changes to go through nearest neighbours case * AVX HOST codes for warp perspective initial * Fixes for accuracy in warp perspective * More fixes for accuracy in warp perspective * Update the cide for AVX version of Planar to Planar * Add bilinear u8 host code for warp perspective * Make updates to include functions for F32 data type * Make updates to use cast instead of set and fix issues with raw C implementation * Add i8 host codes * Add updates for F16 Bilinear Code * Update the initial HIP code for warp perspective * Update fixes for HIP code * Add Warp Perspective Nearest Neighbors F16 code for PKD3_to_PLN3 and PLN3_to_PLN3 * Add updates for PLN to PLN configuration * Add updates for PKD3 to PKD3 case * Rename variables * Update changes to log images separately for Bilinear and Nearest Neighbors * fixed bug in raw c code of PKD-PLN variant * minor bug fix for F16 PLN variants * minor fixes in HOST test suite * Update the HIP code for review comments and refactoring of device functions * Update the comments alignment * Rename functions and add cases in HOST and HIP runTests.py * Update indentations for compuatations and rename vectors * Update documentations and add more reference variables * Make more formatting changes * Make further updates by including test cases * Make updates to use reinterpret cast * Update reinterpret casts for PLN to PLN configuration u8 and i8 codes * Make updates to enclose code inside AVX2 flag * Make further changes to update type casting * Make updates to add warp perspective image * Modify comments, update CHANGELOG and update flags * Update further comments in warp perspective * Add more comments for warp perspective * Update based on further review comments * Update the case number for warp_perspective in common.py * Address review comments * Fix conflits with warp perspective * Update version details * Merge branch 'ar/opt_warp_perspective' of https://github.com/r-abishek/rpp into opt_warp_perspective_rebased * Update version to 1.9.10 including warp perspective * Updates to convert to XYWH from LTRB instead of opposite * Update CHANGELOG.md Co-authored-by: spolifroni-amd <[email protected]> * Revert changes and convert to ltrb instead of xywh --------- Co-authored-by: Srihari-mcw <[email protected]> Co-authored-by: sampath1117 <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> Co-authored-by: Rajy Rawther <[email protected]> Co-authored-by: spolifroni-amd <[email protected]> * Package - Updates and bugfixes (r-abishek#488) * Package - remove clang from test * CMakeLists - remove BUILD_WITH_AMD_ADVANCE * Package - Add OMP dependency * Find Packages - Updates * Test Package - Deps * Test - backend Info * Tests - Fix HIP Test Add * Test - Add HIP Path * Test - Find HIP Updates * Tests - Fix HIP compilation * Jenkins - Fix Test (r-abishek#489) * Jenkins - Fix Test * Test - Create sepreate test folder * FileSystem - Find and process * Find Filesystem - Updates * Test - Compiler Updates * Docs - Bump rocm-docs-core[api_reference] from 1.11.0 to 1.12.0 in /docs/sphinx (r-abishek#491) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.11.0 to 1.12.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.11.0...v1.12.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Docs - Bump rocm-docs-core[api_reference] from 1.12.0 to 1.12.1 in /docs/sphinx (r-abishek#495) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.12.0 to 1.12.1. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.12.0...v1.12.1) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Updates and Fixes - Compiler & Libs (r-abishek#493) * Test Suite - Fix HIP Link * Tests - HIP Updates * Test - Link OpenCV * Test - Link dir updates * CMakeLists - Updates * Test Package - Deps * CXX Compiler & ROCm path updates * ROCm Path - Display info * OpenMP - Updates * Package Deps - Remove OpenMP * jpeg * Compiler updates - C++ 14 Removal (r-abishek#496) * pthread removal * c++14 removal --------- Co-authored-by: Kiriti Gowda <[email protected]> * Docs - Bump rocm-docs-core[api_reference] from 1.12.1 to 1.13.0 in /docs/sphinx (r-abishek#500) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.12.1 to 1.13.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.12.1...v1.13.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * zigzag ordering * zigzag ordering * Compiler updates - C++ 14 Removal (r-abishek#496) * pthread removal * c++14 removal --------- Co-authored-by: Kiriti Gowda <[email protected]> * Readme & Package - Updates (r-abishek#503) * Readme - Updates * Package - Deps to OpenMP * Tests - Rename tensor tests for clarity (r-abishek#469) * Rename Tensor_host to Tensor_image_host, and runTests to runImageTests * Rename Tensor_hip to Tensor_image_hip, and runTests to runImageTests * Rename all readme runTests.py to runImageTests.py --------- Co-authored-by: Kiriti Gowda <[email protected]> Co-authored-by: Srihari-mcw <[email protected]> * minor changes * Tests - Rename tensor tests for clarity (r-abishek#469) * Rename Tensor_host to Tensor_image_host, and runTests to runImageTests * Rename Tensor_hip to Tensor_image_hip, and runTests to runImageTests * Rename all readme runTests.py to runImageTests.py --------- Co-authored-by: Kiriti Gowda <[email protected]> Co-authored-by: Srihari-mcw <[email protected]> * RPP Threshold - HOST and HIP implementation (r-abishek#456) * added initial support for U8 PLN1-PLN1 variant * added support for U8 PKD3, PLN3 variants * modified algorithm to give RGB output for RGB images * moved common code outside the layout branch conditions * added support for toggle variation of U8 * added golden output for threshold * added threshold output for doxygen * added support for F32 bit depth * added support for I8 bitdepth * added F16 bitdepth support * added HIP support for U8 bitdepth * made changes to support remaining bitdepths * fixed output issues with I8 variant * removed commented code in HOST * added threshold test case in maps used in common.py * modified RPP_VERSION_MINOR value and changelog * fixed issues with doxygen modified globalThreads_x value for HIP kernel * made changes in I8 variants as per review comments * added more details for threshold documentation * Update version to 1.9.10 including threshold * Remove duplicate definitions of functions and minor bug fix * Minor docs fix * Minor docs fix --------- Co-authored-by: sampath1117 <[email protected]> Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> Co-authored-by: Srihari-mcw <[email protected]> * RPP Rain augmentation - HOST and HIP implementation (r-abishek#463) * Add Intial u8 implementation for Rain * Add I8 implementation and Changes based on the Review comments * Initial HIP implementation Add F32 and F16 Tensor Implementation * Add test case for Rain in HIP test suite code cleanup * minor code cleanup * Modified func names and removed unnecessary code * Resolve Review comments * replaced pinned memory with HIP memory for Rain Layer computation * Modified RGB Rain Mask to planar Rain Mask in HIP * Address review comments * Add Rain compute function * Add version changes and Resolve review comments * fix build warnings * Fix the outputs of f16 toggle variants * Revert Rain width changes * Fix pln3 outputs for u8 and i8 bitdepths * Resolve review comments * Modified load and store routines for planar cases * Resolve review comments * Modify docs image * Fix versioning * Updates to 1.9.10 including rain feature --------- Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> Co-authored-by: Srihari-mcw <[email protected]> * Docs - Created a more comprehensive installation from the readme information (r-abishek#504) Co-authored-by: Kiriti Gowda <[email protected]> * Test suite build fix - Lock to specific 'nifti_clib' commit (r-abishek#506) * Lock nifti_clib commit in readme * Lock nifti_clib commit in common.groovy * Change to sudo apt install half in common.groovy * Debugging stage * Test Package - Updates (r-abishek#507) * Test suite - Error code detection and display (r-abishek#483) * experimental changes to detect error and print in the end in image test suite * Error handling added for host side * Error detection implemented on HIP SIDE * Voxel test suite changes * Changed variable name to camelCase * Changes in srcpath * Changes in Voxel test suite for nonQA case * Consolidated the repeated code and move it as common code * Minor changes based on review commands * Modification for bitDepth in voxel host * Merge with develop branch * Fix on error code display and gaussian Filter * F string bug is resolved * Fix for CI failure and some improvement in error detection * Changes based on review comments * Fix for rain and warp_perspective issue of unable to open file * Enhanced display for non implimented functionality --------- Co-authored-by: sampath1117 <[email protected]> Co-authored-by: dineshbabu-ravichandran <[email protected]> Co-authored-by: dineshbabu-ravichandran <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> Co-authored-by: HazarathKumarM <[email protected]> * Test Suite - ENUMs for all augmentations to enhance test suite readability (r-abishek#499) * initial commit * removed the usage of supported case list on HOST backend * Add Augmentation enum * removed supported caselists from all the python scripts in HIP backend * replacing case numbers with the enum's on the test suite files * Fix Indentation * Add enums for the swith cases * update Enum's for new cases * Fix errors in unit tests * Semicolon typo fix * Fix the test case naming in QA mode * removes unncessary print statements --------- Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> * OpenMP - Updates (r-abishek#510) * Update common.groovy * Fixes for Segmentation fault * Docs - Bump rocm-docs-core[api_reference] from 1.13.0 to 1.14.1 in /docs/sphinx (r-abishek#511) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.13.0 to 1.14.1. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.13.0...v1.14.1) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Test - Change sprintf to snprintf (r-abishek#512) Co-authored-by: Kiriti Gowda <[email protected]> * Jpeg PKD3 to PKD3 till DCT INV * RPP Bitwise - XOR on HOST and HIP (r-abishek#464) * Update the initial CODE for HIP Implementation of Exclusive OR * Add exclusive_or.hpp hip file * Update the code for initial HOST Code * Make SSE based updatess for exclusive or * Update the code for AVX2 implementation of U8 code * Uncomment pragma * Initial commit for I8 * Add I8 case * Fix issues with PKD3 to PLN3 i8 implementation * Initial updates based on self review * More updates * More cleanup * Update separate code for PLN3 to PLN3 U8 * Update separate code for PLN3 to PLN3 I8 * Update separate code for PLN3 to PLN3 F32 * Fix compilation issues * Fix accuracy issues for PLN3 to PLN3 * Add comments and formatting * Rearrange the function declarations * Add golden outputs for exclusive or * Add AVX2 flags wherever necessary * Update the code to have updated F16 load functions * HIP Code Updates * F16 PLN3 to PLN3 Updates * Update outputs * Rearrange XOR GPU function header * Add empty line * Update aligned length * Updates to make F16 outputs consistent with other bit depths * Add std::nearbyintf in exclusive or hip code * Update the code to use predefined zero vectors * Update to use existing rpp_load96_u8_avx instead of rpp_load96_u8pln3_to_u8pln3 * Update the version * Update changelog * Update CHANGELOG.md * Updates to fix more merge conflicts * Update version to 1.9.10 including exclusive or * Remove duplicate definitions of functions * Updates to just have u8 version of exclusive OR * Fix issues with xor after changes * Update changes to rename exclusive OR to bitwise xor and retain U8 data type alone * Update test suite to have only U8 bit depth * Update test suite to have only U8 bit depth on HOST also * Update condition for data type check * Update condition again for data type check --------- Co-authored-by: Srihari-mcw <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> * Docs - miscellaneous changes (r-abishek#508) * added the image from whatis/readme to the front page * added back the misisng install file into the TOC * added a note about CPU being HOST; added audio functionality; modified the toc * added a reference file for the api that acts as the anchor for a sublist in the toc * Fixing problems with api ref links * Still trying to fix the problems with api ref links --------- Co-authored-by: Kiriti Gowda <[email protected]> * jpeg PKD3 to PKD3 with a little distortion * Docs - Bump rocm-docs-core[api_reference] from 1.14.1 to 1.15.0 in /docs/sphinx (r-abishek#515) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.14.1 to 1.15.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.14.1...v1.15.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Jpeg u8 all layouts * Jpeg all layouts U8, F32 * Jpeg Compression all variants in all layouts * Package - Updates for RPM (r-abishek#519) * JPEG Compression distortion * PKD3 PLN3 QA * Docs - Bump rocm-docs-core[api_reference] from 1.15.0 to 1.17.0 in /docs/sphinx (r-abishek#521) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.15.0 to 1.17.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.15.0...v1.17.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * CMakeLists - gfx updates (r-abishek#516) * gfx updates * rocm version check for targets * Use rocm_check_target_ids if available * move gfx942 to default list --------- Co-authored-by: Kiriti Gowda <[email protected]> Co-authored-by: Cordell Bloor <[email protected]> * RPP Restructure - Consolidate handle creation and destruction APIs (r-abishek#513) * Changed to rppcreateHost and rppCreateGPU * Added rppCreate for HOST and HIP * Completely removed RppCreateHOST and rppCreateHIP on BatchPD. * Destroy HOST and GPU is removed * Changes based on review comments * Separated thread and stream as a separate argument * Retained setStream api and related functions * Minor docs fix * Removed empty line * Update CHANGELOG.md * Update CHANGELOG.md version to 1.9.11 * Update CMakeLists.txt version to 1.9.11 * Update rpp_version.h version to 1.9.11 * Update CHANGELOG.md Co-authored-by: spolifroni-amd <[email protected]> * Update CHANGELOG.md Co-authored-by: spolifroni-amd <[email protected]> * Update CHANGELOG.md Co-authored-by: spolifroni-amd <[email protected]> * Update CHANGELOG.md Co-authored-by: spolifroni-amd <[email protected]> * Update CHANGELOG.md Co-authored-by: spolifroni-amd <[email protected]> * Update CHANGELOG.md Co-authored-by: spolifroni-amd <[email protected]> * Update CHANGELOG.md Co-authored-by: spolifroni-amd <[email protected]> * Update CHANGELOG.md Co-authored-by: spolifroni-amd <[email protected]> * Update CHANGELOG.md Co-authored-by: spolifroni-amd <[email protected]> * Update CHANGELOG.md for rppCreate and rpp Destroy * Update CHANGELOG.md Co-authored-by: spolifroni-amd <[email protected]> * Update CHANGELOG.md Co-authored-by: spolifroni-amd <[email protected]> * Update CHANGELOG.md Co-authored-by: spolifroni-amd <[email protected]> * Update CHANGELOG.md * Update CHANGELOG.md for RPP 2.0.0 * Update CMakeLists.txt for RPP 2.0.0 * Update rpp_version.h for RPP 2.0.0 --------- Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> Co-authored-by: spolifroni-amd <[email protected]> * RPP Tensor Support - Bitwise NOT, Bitwise AND, Bitwise OR (r-abishek#520) * Add Initial implementation of Bitwise NOT in HOST backend * Add HIP Implementation for Bitwise Not kernel * Add Bitwise NOT implementation for I8, F32 and F16 bitdepths * Fix output issues for float variants * code cleanup * Modify aligned Length for pln3-pln3 conversion * Modified the casting style and updated doc images * update augmentations maps in test suite * Changes for converting bitwise or and and into u8 bitdepth * Changes for solving build errors * bitwise and & or for u8 on HOST * Minor changes to resolve error due to merging * Limited only support for U8 * Renaming from logical to bitwise * Golden output file is added * Changes based on review comments * REmoved changes in host_logical_operationss.hpp * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> * Docs - Bump rocm-docs-core[api_reference] from 1.17.0 to 1.17.1 in /docs/sphinx (r-abishek#523) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.17.0 to 1.17.1. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.17.0...v1.17.1) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * RPP Test Suite - Bugfixes for Gaussian filter and QA test summary (r-abishek#524) * Fix the summary and fix the unit test issues of Gaussian filter * Fix performance tests summary table * fix unit test path * revert change * revert changes --------- Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> * compact code * corrections after merge * minor modification * minor modification * revert changes * cleanup the code * revert merge changes * cleanup the code * updated the doxygen comments and cleanup * resolve review comments * Fix review comments * resolve merge issues * resolve review comments * cleanup the code * Resolve review comments * Optimize dct fwd and inverse functions * resolve review comments * categorized the code * moved common code of all function * Add comments for load/store functions * Update license to 2025 * Update CHANGELOG.md * Fix docs Co-authored-by: Copilot <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sampath1117 <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]> Co-authored-by: HazarathKumarM <[email protected]> Co-authored-by: Lakshmi Kumar <[email protected]> Co-authored-by: Rajy Rawther <[email protected]> Co-authored-by: spolifroni-amd <[email protected]> Co-authored-by: Srihari-mcw <[email protected]> Co-authored-by: ManasaDattaT <[email protected]> Co-authored-by: Hansel Yang <[email protected]> Co-authored-by: dineshbabu-ravichandran <[email protected]> Co-authored-by: dineshbabu-ravichandran <[email protected]> Co-authored-by: root <[email protected]> Co-authored-by: Cordell Bloor <[email protected]> Co-authored-by: Copilot <[email protected]>
Mem copy eliminated and used hipHostMalloc for allocation for the following kernels