AUDIO Support - Fix Copilot comments#498
Merged
r-abishek merged 4 commits intor-abishek:ar/audio_support_qa_samplesfrom Oct 2, 2025
Merged
AUDIO Support - Fix Copilot comments#498r-abishek merged 4 commits intor-abishek:ar/audio_support_qa_samplesfrom
r-abishek merged 4 commits intor-abishek:ar/audio_support_qa_samplesfrom
Conversation
r-abishek
approved these changes
Sep 26, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the audio processing test suite by splitting a generic AUDIO_MAX_HEIGHT constant into more specific, semantically clear constants for different audio operations.
- Split
AUDIO_MAX_HEIGHTintoMEL_FILTER_BANK_MAX_HEIGHTandSPECTROGRAM_MAX_HEIGHTfor better code clarity - Updated all references to use the appropriate specific constants
- Fixed resample buffer size calculation to use the correct scale factor
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| utilities/test_suite/rpp_test_suite_audio.h | Replaces generic constant with specific constants for mel filter bank and spectrogram operations |
| utilities/test_suite/HOST/Tensor_audio_host.cpp | Updates buffer size calculations to use appropriate specific constants |
| utilities/test_suite/HIP/Tensor_audio_hip.cpp | Updates buffer size calculations and fixes resample buffer calculation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| // compute maximum possible buffer size of resample | ||
| Rpp64u resampleMaxBufferSize = dstDescPtr->n * dstDescPtr->strides.nStride * AUDIO_MAX_HEIGHT; | ||
| Rpp64u resampleMaxBufferSize = dstDescPtr->n * dstDescPtr->strides.nStride * RESAMPLE_BUFFER_SCALE_FACTOR; |
There was a problem hiding this comment.
The resample buffer size calculation appears incorrect. The scale factor (1.16) is being multiplied directly with buffer dimensions, but scale factors are typically used as multipliers of the base buffer size, not as dimensional components. This may result in an undersized buffer.
Suggested change
| Rpp64u resampleMaxBufferSize = dstDescPtr->n * dstDescPtr->strides.nStride * RESAMPLE_BUFFER_SCALE_FACTOR; | |
| Rpp64u resampleMaxBufferSize = static_cast<Rpp64u>(oBufferSize * RESAMPLE_BUFFER_SCALE_FACTOR); |
…access QA golden output from bin files
ManasaDattaT
pushed a commit
to ManasaDattaT/rpp
that referenced
this pull request
Dec 10, 2025
ManasaDattaT
pushed a commit
to ManasaDattaT/rpp
that referenced
this pull request
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.