Codecov Report

Merging #137 into master will decrease coverage by 53.61%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #137       +/-   ##
==========================================
- Coverage   54.93%   1.32%   -53.62%     
==========================================
  Files          24      24               
  Lines        1509    1509               
==========================================
- Hits          829      20      -809     
- Misses        680    1489      +809

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ae5ca6...a2a7896. Read the comment docs.

Kicked off:

devtools::check_win_devel()

To check on the CRAN Windows service that checks on R-devel version - results in a wee while.

just tuned in to the live stream

Looking good!

First feedback - minor setback. Email from win-devel service:

Dear package maintainer,

this notification has been generated automatically.
Your package boxr_0.3.5.tar.gz has been built (if working) and checked for Windows.
Please check the log files and (if working) the binary package at: https://win-builder.r-project.org/3IwWWFu6tXaO/
The files will be removed after roughly 72 hours.
Installation time in seconds: 12
Check time in seconds: 106
Status: 1 NOTE
R Under development (unstable) (2019-11-12 r77405)

All the best,
Uwe Ligges
(CRAN maintainer of binary packages for Windows)

This leads to https://win-builder.r-project.org/3IwWWFu6tXaO/00check.log, which states:

* checking CRAN incoming feasibility ... NOTE
Maintainer: 'Ian Lyttle <[email protected]>'

New maintainer:
  Ian Lyttle <[email protected]>
Old maintainer(s):
  Brendan Rocks <[email protected]>

Found the following (possibly) invalid file URIs:
  URI: README.md
    From: NEWS.md
  URI: R/README.md
    From: NEWS.md

The new-maintainer note is to be expected - gotta fix something in the NEWS...

Fixed (🤞), rinse-and-repeat with check_win_devel().

We got a clean check this time 🎉: https://win-builder.r-project.org/9GR231rqGSnX/00check.log

Next - r-hub checks

Yeaaaa buddy!

Following: https://gargle.r-lib.org/articles/articles/managing-tokens-securely.html

They suggest:

rhub::check(env_vars = Sys.getenv(gargle:::secret_pw_name("gargle"), names = TRUE))

for us, this becomes:

rhub::check(env_vars = Sys.getenv(gargle:::secret_pw_name("boxr"), names = TRUE))

I might do this first, before the CRAN checks, to run the API tests - maybe it will be separate from the CRAN checks.

Choosing option 1: Debian Linux, R-devel, clang, ISO-8859-15 locale (debian-clang-devel)

Maybe we don't even test on rhub? We have working tests on Travis for peace of mind, and even there sometime we have to restart a build to get it to work

i.e. Just pass the empty "" in?

Getting what I think is an unrelated error at rhub: https://builder.r-hub.io/status/boxr_0.3.5.tar.gz-fb2edf8f6c8d489a9dc9e06a936b4fa9

It seems not to be able to load a package.

I agree that this is a bit unrelated, but I wanted to test out the auth system, as advertised.

I think I might move straight for the CRAN checks at r-hub, not using auth:

rhub::check_for_cran()

(just did)

Here's the live status of each:

https://builder.r-hub.io/status/boxr_0.3.5.tar.gz-71793aef252c4e8b98fcfbec3663021c
https://builder.r-hub.io/status/boxr_0.3.5.tar.gz-94d58950645d4d58b8300f0062bd5988
https://builder.r-hub.io/status/boxr_0.3.5.tar.gz-8046cb90d92e483d9c09233da75e6780

100% unrelated, we don't have any Bioconducter dependencies, I'm guessing the Rhub image just pulls all possible installer packages first, BiocManager being one of them.

Not sure this won't crop up later on the psuedo-CRAN check too...

Agreed - sometimes r-hub gets a bit "out-of-sorts", but it has given me useful feedback.

One of the submissions has come back OK - I'll wait a little while for the others.

I'm guessing they will all be okay, the Windows build is the most different from the Travis env.

I have to log off the stream, but if anything comes up let me know and I'll be back later this afternoon. 🤞

rhub checks come back OK

My plan is:

• spell-check the function-documentation
• run remote (win-devel, rhub) checks again
• submit

Am just reminded of devtools::spell_check(), which would have been useful to remember earlier...

🚀

On CRAN 🎉

Stickers inbound! I'm putting one on my machine tonight! Damn it feels good!

Indeed! Thanks for everything you've done!