Fix usethis check error #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lovely, thank you for the fix! |
|
@malcolmbarrett - thanks! @nathancday - I have added a couple things, as I could not bring myself to ask Malcom to add a NEWS item after fixing a bug out-of-the blue :). If this all looks OK to you, I am fine to squash-and-merge. |
|
Ha, a little commit like this hardly deserves a news item! Anyway, my pleasure; we're using this package extensively on our team, and I greatly appreciate your hard work on it! |
|
The really amazing thing, @ijlyttle, is that I was in an environment without usethis 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auth_message()checks if usethis is installed, but it throws an error if it's not (when I saw this in the wild, it threw an error, then printed the second message). This PR changes the related argument ofrequireNamespace()toquietly = TRUEto only returnTRUE/FALSE, not throw an error.