Support Google Cloud Build #469
Merged
+35
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks, this looks good! Can you please add a bullet to NEWS? It should briefly describe the change and end with |
|
Ah thanks! Its been a while so had to remind myself, but I've been using my fork extensively for example during development of https://app.codecov.io/gh/MarkEdmondson1234/googleCloudRunner |
|
Sorry about the delay, I think I was not actively watching this repo when you sent the PR, so didn't see it right away. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets googleCloudRunner upload covr reports directly without needing travis as well.
I referenced the API arguments here: https://docs.codecov.io/reference#upload
I enabled the default substitution variables available in Google Cloud Build here: https://cloud.google.com/build/docs/configuring-builds/substitute-variable-values - creating them as environment arguments for covr to discover with the prefix
GCB_I have some successful Cloud Build reports uploading with this code here: https://app.codecov.io/gh/MarkEdmondson1234/measurementProtocol/