make it possible to add an author with a comment including e.g. an ORCID #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
- Coverage 100% 98.77% -1.23%
==========================================
Files 18 18
Lines 1131 1065 -66
==========================================
- Hits 1131 1052 -79
- Misses 0 13 +13
Continue to review full report at Codecov.
|
|
I can't reproduce the Travis failure locally 🤔 |
|
Oh I know why it fails! One of the tests I've added checks that one can add an ORCID. I check for the string resulting from I'll add some skipping. |
|
Thanks! |
llrs
pushed a commit
to llrs/desc
that referenced
this pull request
Oct 9, 2018
…CID (r-lib#69) * make it possible to add an author with a comment including an ORCID * fix assertion * fix on failure line * fix assertion * add test for NA assertion * skip test on older R versions * add test of failure * typo!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf #65 (in preparation for the PR I intend to do for #63 )
One thing I wasn't sure about is whether you can add anything to the comment field, or whether there's a limited number of named strings that can go in there. I wasn't able to find that in "Writing R extensions" (where the ORCID support isn't documented yet anyway).